linux-kernel - Re: [PATCH v12 20/21] selftests/futex: Add futex_priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36bdcbe1-5f74-4afb-83dd-89f7348aeb5d@sirena.org.uk>
Date: Tue, 27 May 2025 14:40:22 +0100
From: Mark Brown <broonie@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org,
	André Almeida <andrealmeid@...lia.com>,
	Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>, Ingo Molnar <mingo@...hat.com>,
	Juri Lelli <juri.lelli@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v12 20/21] selftests/futex: Add futex_priv_hash

On Tue, May 27, 2025 at 03:25:33PM +0200, Sebastian Andrzej Siewior wrote:
> On 2025-05-27 13:59:38 [+0100], Mark Brown wrote:

> >    https://builds.sirena.org.uk/cda95faef7bcf26ba3f54c3cddce66d50116d146/arm64/defconfig/build.log
> >    https://builds.sirena.org.uk/cda95faef7bcf26ba3f54c3cddce66d50116d146/arm64/defconfig/kselftest.tar.xz

> > (note that this is the specific commit that I'm replying to the patch

> Ach, okay. I assumed you had the master branch as of today. The whole
> KTAP/ machine readable output was added later.



> > for, not -next.)  It looks like it's something's getting mistbuilt or
> > there's some logic bug with the argument parsing, if I run the binary
> > with -h it exits with return code 0 rather than 1.

> I copied the logic from the other tests in that folder. If you set -h (a
> valid argument) then it exits with 0. If you an invalid argument it
> exits with 1.

Yeah, so it was actually parsing arguments.

> But now that I start the binary myself, it ends the same way. This
> cures it:

>  	int ret;
> -	char c;
> +	int c;
>  
>  	while ((c = getopt(argc, argv, "cghv:")) != -1) {

Ah, yes - that'd do it.  Looking at the other tests there they do have c
as int.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)