linux-kernel - Re: [PATCH 2/5] dt-bindings: media: allegro-dvt: add decoder dt-bindings for Gen3 IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <kqrngtgusod4cczeh33lz4seclgzn655ucnuhu76zh7ylrsybo@ndrecjbqvma4>
Date: Tue, 27 May 2025 14:33:09 +0000
From: Yassine Ouaissa <yassine.ouaissa@...egrodvt.com>
To: Nicolas Dufresne <nicolas@...fresne.ca>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Michael Tretter <m.tretter@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Michal Simek <michal.simek@....com>, Heiko Stuebner <heiko@...ech.de>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Junhao Xie <bigfoot@...ssfun.cn>, 
	Rafa?? Mi??ecki <rafal@...ecki.pl>, Kever Yang <kever.yang@...k-chips.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Hans Verkuil <hverkuil@...all.nl>, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>, Sebastian Fricke <sebastian.fricke@...labora.com>, 
	Gaosheng Cui <cuigaosheng1@...wei.com>, Uwe Kleine-K??nig <u.kleine-koenig@...libre.com>, 
	Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Ricardo Ribalda <ribalda@...omium.org>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/5] dt-bindings: media: allegro-dvt: add decoder
 dt-bindings for Gen3 IP

On 27.05.2025 09:21, Nicolas Dufresne wrote:
>Hi Yassine,
>
>Le lundi 26 mai 2025 à 12:58 +0000, Yassine Ouaissa a écrit :
>> On 26.05.2025 14:46, Krzysztof Kozlowski wrote:
>> > On 26/05/2025 14:27, Yassine Ouaissa wrote:
>> > > On 26.05.2025 12:57, Krzysztof Kozlowski wrote:
>> > > > On 26/05/2025 09:25, Yassine Ouaissa wrote:
>> > > > > On 23.05.2025 19:13, Krzysztof Kozlowski wrote:
>> > > > > > On 23/05/2025 19:11, Krzysztof Kozlowski wrote:
>> > > > > > > On 23/05/2025 15:41, Yassine Ouaissa wrote:
>> > > > > > > > Add compatible for video decoder on allegrodvt Gen 3 IP.
>> > > > > > > >
>> > > > > > > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@...egrodvt.com>
>> > > > > > > Please do not send the same patches over and over again. You got review
>> > > > > > > which you need to address.
>> > > > > > >
>> > > > > > > Once address you send NEXT version with proper CHANGELOG for each patch
>> > > > > > > or top of cover letter. See submitting patches... or just use b4. This
>> > > > > > > should be actually requirement for this work.
>> > > > > > >
>> > > > > > > Anyway, I see all of previous review ignored so let's be explicit:
>> > > > > > >
>> > > > > > > NAK
>> > > > > > >
>> > > > > Hi Krzysztof,
>> > > > >
>> > > > > Make sure that i'm not ignoring anyone reviews, i sent a new set of
>> > > > > patches to start cleanly, and i have sent you an email about this.
>> > > >
>> > > > It is still v1 - the same? - while you already sent three patchsets before.
>> > >
>> > > As i mentioned, this patch is sent to start cleanly, so it still v1.
>> > > And the previous patchsets should be ignored.
>> > This is not how the process works and it is not making reviewers life
>> > easier. It makes it impossible for us to compare (try yourself with `b4
>> > diff`) and forces to re-review everything every time.
>>
>> I know that i made a mistake by not respecting the "submitting patches".
>> this is why, i prefer to start from a good base ( clean patches ).
>>  From this patchsets, You & I can use the b4 or other tools to get the diffs.
>
>For future submissions, once there is a base, don't try and "fix" things, just do
>add V2, V3 on future submissions, even if its completely rewritten. Just say so in
>your cover letter change log. If everyone was to reset to V1 all the time our work
>as reviewer and maintainers would be completely un-manageable. Please understand
>and take our explanations for the future. There is no need for you to argue on this,
>this is not just personal preference. Same driver, second submission mean v2. That is
>even true if you take over someone else series.

I'm aware of that, sins i started using the b4 tool.
Thanks.
>
>regards,
>Nicolas
>
>>

Best regards,
Yassine OUAISSA
>> >
>> > Best regards,
>> > Krzysztof
>>
>> Best regards,
>> Yassine OUAISSA