linux-kernel - Re: [PATCH 1/1] dt-bindings: interrupt-controller: Add fsl,icoll.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250527-ancient-monstrous-2b867b95524b@spud>
Date: Tue, 27 May 2025 16:47:46 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:IRQCHIP DRIVERS" <linux-kernel@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: interrupt-controller: Add fsl,icoll.yaml

On Fri, May 23, 2025 at 03:20:15PM -0400, Frank Li wrote:
> Add fsl,icoll.yaml for i.MX23 and i.MX28.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  .../interrupt-controller/fsl,icoll.yaml       | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml
> new file mode 100644
> index 0000000000000..7b09fd7d588f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,icoll.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/fsl,icoll.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS icoll Interrupt controller
> +
> +maintainers:
> +  - Frank Li <Frank.Li@....com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - fsl,imx23-icoll
> +              - fsl,imx28-icoll
> +          - const: fsl,icoll

Given this generic fallback, that would likely not be approved if this
were actually what it is presented as (a binding for some new device),
is only acceptable because it is already in use and this is some 15 year
old device, you should state pretty clearly in your commit message.
With it pointed out,
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    interrupt-controller@...00000 {
> +        compatible = "fsl,imx28-icoll", "fsl,icoll";
> +        reg = <0x80000000 0x2000>;
> +        interrupt-controller;
> +        #interrupt-cells = <1>;
> +    };
> +
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)