[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250527032701-GYA55693@gentoo>
Date: Tue, 27 May 2025 03:27:01 +0000
From: Yixun Lan <dlan@...too.org>
To: Guodong Xu <guodong@...cstar.com>
Cc: Uwe Kleine-König <ukleinek@...nel.org>,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
alex@...ti.fr, p.zabel@...gutronix.de, drew@...7.com,
inochiama@...il.com, geert+renesas@...der.be, heylenay@....org,
tglx@...utronix.de, hal.feng@...rfivetech.com,
unicorn_wang@...look.com, duje.mihanovic@...le.hr,
heikki.krogerus@...ux.intel.com, elder@...cstar.com,
linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
spacemit@...ts.linux.dev
Subject: Re: [PATCH v3 4/6] riscv: dts: spacemit: add pwm14_1 pinctrl setting
Hi Guodong,
On 10:48 Tue 27 May , Guodong Xu wrote:
> On Tue, May 27, 2025 at 5:52 AM Yixun Lan <dlan@...too.org> wrote:
> >
> > Hi Guodong, Uwe,
> >
> > On 18:54 Mon 26 May , Uwe Kleine-König wrote:
> > > On Tue, Apr 29, 2025 at 04:50:46PM +0800, Guodong Xu wrote:
> > > > diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > > index 283663647a86..195eb8874f3c 100644
> > > > --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > > +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > > @@ -20,4 +20,11 @@ uart0-2-pins {
> > > > drive-strength = <32>;
> > > > };
> > > > };
> > > > + pwm14_1_cfg: pwm14-1-cfg {
> > > > + pwm14-1-pins {
> > > > + pinmux = <K1_PADCONF(44, 4)>;
> > > > + bias-pull-up = <0>;
> > > > + drive-strength = <32>;
> > > > + };
> > > > + };
> > >
> > > There is a newline expected before the pwm14-1-cfg node, isn't there?
> > >
> > Right, I could amend this and fix it while applying this patch
> > (so if there is no other serious issue, no need to resend)
> >
>
> Thanks, Yixun.
>
> By the way, do you plan to take patches 3 and 4 of this series into
> your tree? They only apply if the SpacemiT reset patchset is applied
> first.
>
Yes, exactly. The dts patch will go through SpacemiT SoC tree, and we
have to wait untill reset patch series applied.
--
Yixun Lan (dlan)
Powered by blists - more mailing lists