linux-kernel - Re: [PATCH v2 3/3] riscv: dts: sophgo: Add SPI NOR node for SG2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mafs05xhmro7q.fsf@kernel.org>
Date: Tue, 27 May 2025 18:51:53 +0200
From: Pratyush Yadav <pratyush@...nel.org>
To: Zixian Zeng <sycamoremoon376@...il.com>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,  Pratyush Yadav
 <pratyush@...nel.org>,  Michael Walle <mwalle@...nel.org>,  Miquel Raynal
 <miquel.raynal@...tlin.com>,  Richard Weinberger <richard@....at>,
  Vignesh Raghavendra <vigneshr@...com>,  Chen Wang
 <unicorn_wang@...look.com>,  Inochi Amaoto <inochiama@...il.com>,  Mark
 Brown <broonie@...nel.org>,  Rob Herring <robh@...nel.org>,  Krzysztof
 Kozlowski <krzk+dt@...nel.org>,  Conor Dooley <conor+dt@...nel.org>,  Paul
 Walmsley <paul.walmsley@...ive.com>,  Palmer Dabbelt <palmer@...belt.com>,
  Albert Ou <aou@...s.berkeley.edu>,  Alexandre Ghiti <alex@...ti.fr>,
  Longbin Li <looong.bin@...il.com>,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org,  sophgo@...ts.linux.dev,
  linux-spi@...r.kernel.org,  devicetree@...r.kernel.org,
  linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] riscv: dts: sophgo: Add SPI NOR node for SG2042

On Sun, May 25 2025, Zixian Zeng wrote:

> Add SPI-NOR controller and flash nodes to device tree for SG2042.
>
> Signed-off-by: Zixian Zeng <sycamoremoon376@...il.com>
> ---
>  .../riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts | 18 ++++++++++++++++
>  arch/riscv/boot/dts/sophgo/sg2042.dtsi             | 24 ++++++++++++++++++++++
>  2 files changed, 42 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> index 34645a5f6038389cd00d4940947c6bb71d39ec6f..c59a819e35d3201c484bf98392aec14392a7eb04 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> @@ -68,6 +68,24 @@ &sd {
>  	status = "okay";
>  };
>  
> +&spifmc0 {
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "jedec,spi-nor";
> +		reg = <0>;

Shouldn't you also add other properties like spi-max-frequency or
spi-{rx,tx}-bus-width? Same for the other flash.

> +	};
> +};
> +
> +&spifmc1 {
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "jedec,spi-nor";
> +		reg = <0>;
> +	};
> +};
> +
>  &uart0 {
>  	status = "okay";
>  };
[...]

-- 
Regards,
Pratyush Yadav