linux-kernel - Re: [PATCH v4 14/26] arm64/sysreg: Add ICH_HFGITR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDcd+CyDORzgkfXK@lpieralisi>
Date: Wed, 28 May 2025 16:30:16 +0200
From: Lorenzo Pieralisi <lpieralisi@...nel.org>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Sascha Bischoff <sascha.bischoff@....com>,
	Timothy Hayes <timothy.hayes@....com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Mark Rutland <mark.rutland@....com>,
	Jiri Slaby <jirislaby@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 14/26] arm64/sysreg: Add ICH_HFGITR_EL2

On Wed, May 28, 2025 at 12:28:26PM +0100, Jonathan Cameron wrote:
> On Tue, 13 May 2025 19:48:07 +0200
> Lorenzo Pieralisi <lpieralisi@...nel.org> wrote:
> 
> > Add ICH_HFGITR_EL2 register description to sysreg.
> > 
> > Signed-off-by: Lorenzo Pieralisi <lpieralisi@...nel.org>
> > Cc: Will Deacon <will@...nel.org>
> > Cc: Catalin Marinas <catalin.marinas@....com>
> > Cc: Marc Zyngier <maz@...nel.org>
> 
> Hi Lorenzo,
> 
> > ---
> >  arch/arm64/tools/sysreg | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> > index 0927754d9fe2c5addbd9693d83b7324f1af66d3e..d2f53fb7929c69895fe8a21ba625d058a844d447 100644
> > --- a/arch/arm64/tools/sysreg
> > +++ b/arch/arm64/tools/sysreg
> > @@ -3616,6 +3616,21 @@ Res0	1
> >  Field	0	ICC_APR_EL1
> >  EndSysreg
> >  
> > +Sysreg	ICH_HFGITR_EL2	3	4	12	9	7
> > +Res0	63:11
> > +Field	10	GICRCDNMIA
> > +Field	9	GICRCDIA
> > +Field	8	GICCDDI
> > +Field	7	GICCDEOI
> > +Field	6	GICCDHM
> > +Field	5	GICCRDRCFG
> 
> GICCDRCFG in the spec. (you have a bonus R)

Bah. Good catch - I should move to autogeneration.

> Of course the real question was what am I avoiding that made checking these
> against the spec feel like a good idea? :)

:)

> FWIW with that fixed,
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> for patches 2 to 14.

Thanks,
Lorenzo

> > +Field	4	GICCDPEND
> > +Field	3	GICCDAFF
> > +Field	2	GICCDPRI
> > +Field	1	GICCDDIS
> > +Field	0	GICCDEN
> > +EndSysreg
> > +
> >  Sysreg	ICH_HCR_EL2	3	4	12	11	0
> >  Res0	63:32
> >  Field	31:27	EOIcount
> > 
>