linux-kernel - Re: [PATCH] tools/testing/vma: add missing function stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2zr7b6mawiqiwczuyfolwdqw662binsxjnwv7ou25reqvbmhqv@5ije6q7b4mom>
Date: Wed, 28 May 2025 10:40:34 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: lorenzo.stoakes@...cle.com
Cc: Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>,
        Pedro Falcato <pfalcato@...e.de>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/testing/vma: add missing function stub

* Lorenzo Stoakes via B4 Relay <devnull+lorenzo.stoakes.oracle.com@...nel.org> [250528 10:16]:
> From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> 
> The hugetlb fix introduced in commit ee40c9920ac2 ("mm: fix copy_vma()
> error handling for hugetlb mappings") mistakenly did not provide a stub for
> the VMA userland testing, which results in a compile error when trying to
> build this.
> 
> Provide this stub to resolve the issue.

I need to be more careful in reviews for these things in the future.

LGTM.

Reviewed-by:  Liam R. Howlett <Liam.Howlett@...cle.com>

> 
> ---
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> ---
>  tools/testing/vma/vma_internal.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tools/testing/vma/vma_internal.h b/tools/testing/vma/vma_internal.h
> index f6e45e62da3a6ee007b7431573f27ef5c2533865..441feb21aa5a92b7edddb07258c7f368171de15b 100644
> --- a/tools/testing/vma/vma_internal.h
> +++ b/tools/testing/vma/vma_internal.h
> @@ -1461,4 +1461,9 @@ static inline int __call_mmap_prepare(struct file *file,
>  	return file->f_op->mmap_prepare(desc);
>  }
>  
> +static inline void fixup_hugetlb_reservations(struct vm_area_struct *vma)
> +{
> +	(void)vma;
> +}
> +
>  #endif	/* __MM_VMA_INTERNAL_H */
> 
> ---
> base-commit: 1637eadc7fdf2fa4069a149b1e836656a3b64150
> change-id: 20250528-fix-vma-test-57b138f28f46
> 
> Best regards,
> -- 
> Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> 
>