linux-kernel - Re: [net-next PatchV2] octeontx2-pf: ethtool: Display "Autoneg" and "Port" fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250527171822.030f5f75@kernel.org>
Date: Tue, 27 May 2025 17:18:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hariprasad Kelam <hkelam@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Sunil Goutham
 <sgoutham@...vell.com>, Linu Cherian <lcherian@...vell.com>, Geetha
 sowjanya <gakula@...vell.com>, Jerin Jacob <jerinj@...vell.com>, Subbaraya
 Sundeep <sbhatta@...vell.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Bharat Bhushan <bbhushan2@...vell.com>
Subject: Re: [net-next PatchV2] octeontx2-pf: ethtool: Display "Autoneg" and
 "Port" fields

On Fri, 23 May 2025 16:56:38 +0530 Hariprasad Kelam wrote:
> +	case PORT_TP:
> +	case PORT_AUI:
> +		cmd->base.port = rsp->fwdata.port;
> +		break;

You're running 10g Ethernet over a 15 pin serial port? :/
AFAIU PORT_AUI refers to 30 year old, 10Mbps connectors.
You probably mean PORT_DA (Direct Attached [Copper]) ?

If that's right and the FW gets it wrong just fix it up in the driver?

	case PORT_AUI: /* FW uses the wrong ID for DA */
		cmd->base.port = PORT_DA;
		break;

? Please note that net-next is now closed for 2 weeks of the merge
window.
-- 
pw-bot: cr