linux-kernel - Re: [PATCH v2 01/13] rust: pin-init: rename `zeroed` to `init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DA7W7FU3XF0C.3N7KB44MCSPTG@kernel.org>
Date: Wed, 28 May 2025 17:18:32 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: Benoît du Garreau <benoit@...arreau.fr>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>, "Fiona Behrens" <me@...enk.dev>,
 "Christian Schrefl" <chrisi.schrefl@...il.com>, "Alban Kurti"
 <kurti@...icto.ai>, "Michael Vetter" <jubalh@...oru.org>, "Lyude Paul"
 <lyude@...hat.com>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 01/13] rust: pin-init: rename `zeroed` to
 `init_zeroed`

On Tue May 27, 2025 at 11:54 PM CEST, Benoît du Garreau wrote:
> On Fri, 23 May 2025 16:50:57 +0200 Benno Lossin <lossin@...nel.org> wrote:
>> @@ -1469,7 +1469,7 @@ pub unsafe trait PinnedDrop: __internal::HasPinData {
>>  /// this is not UB:
>>  ///
>>  /// ```rust,ignore
>> -/// let val: Self = unsafe { core::mem::zeroed() };
>> +/// let val: Self = unsafe { core::mem::init_zeroed() };
>
> This looks like a find/replace that was a bit too eager :)

Oh yeah! Thanks for spotting this!

---
Cheers,
Benno