| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aDcrcIB1zBVtxnne@lizhi-Precision-Tower-5810>
Date: Wed, 28 May 2025 11:27:44 -0400
From: Frank Li <Frank.li@....com>
To: Rob Herring <robh@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Dong Aisheng <aisheng.dong@....com>, Jacky Bai <ping.bai@....com>,
NXP S32 Linux Team <s32@....com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: gpio: Move fsl,mxs-pinctrl.txt into
gpio-mxs.yaml
On Tue, May 27, 2025 at 01:18:03PM -0500, Rob Herring wrote:
> On Fri, May 23, 2025 at 04:31:57PM -0400, Frank Li wrote:
> > Move mxs-pinctrl part into gpio-mxs.yaml and add pinctrl examples to fix
> > below CHECK_DTB warning:
> >
> > arch/arm/boot/dts/nxp/mxs/imx28-xea.dtb: pinctrl@...18000 (fsl,imx28-pinctrl):
> > 'auart0-2pins@0', 'auart0@0', ... 'usb1@1' do not match any of the regexes: 'gpio@[0-9]+$', 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> > .../devicetree/bindings/gpio/gpio-mxs.yaml | 73 +++++++++-
> > .../bindings/pinctrl/fsl,mxs-pinctrl.txt | 127 ------------------
> > 2 files changed, 69 insertions(+), 131 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,mxs-pinctrl.txt
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml
> > index b58e08c8ecd8a..b3cf4682be3fd 100644
> > --- a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml
> > @@ -18,9 +18,11 @@ description: |
> >
> > properties:
> > compatible:
> > - enum:
> > - - fsl,imx23-pinctrl
> > - - fsl,imx28-pinctrl
> > + items:
> > + - enum:
> > + - fsl,imx23-pinctrl
> > + - fsl,imx28-pinctrl
> > + - const: simple-bus
>
> I don't think the use of simple-bus is correct here. The addresses are
> not MMIO (there's no size), and I would guess the child nodes are
> dependent on the parent.
This is legency device, which more than 10 years. It use simple-bus
to probe children gpio devices. pinctrl have not use it.
>
> >
> > '#address-cells':
> > const: 1
> > @@ -31,6 +33,61 @@ properties:
> > maxItems: 1
> >
> > patternProperties:
> > + "^(?!gpio).*@[0-9]+$":
>
> Unit-address should be hex? If not, then another reason this is not a
> simple-bus.
Yes, it is wrong to use simple-bus in old driver and dts
drivers/gpio/gpio-mxs.c
It is not worth to fix driver and dts for such old lagency devices. Although
chip is still shipping, we have not board to test it.
>
> > + type: object
> > + properties:
> > + fsl,pinmux-ids:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description: |
> > + An integer array. Each integer in the array specify a pin
> > + with given mux function, with bank, pin and mux packed as below.
> > +
> > + [15..12] : bank number
> > + [11..4] : pin number
> > + [3..0] : mux selection
> > +
> > + This integer with mux selection packed is used as an entity by both group
> > + and config nodes to identify a pin. The mux selection in the integer takes
> > + effects only on group node, and will get ignored by driver with config node,
> > + since config node is only meant to set up pin configurations.
> > +
> > + Valid values for these integers are listed below.
> > +
> > + reg:
> > + maxItems: 1
>
> Would be good to say what 'reg' represents here.
It is just a index, which are not use by drivers. But need it to dts build
issue.
Frank
>
> > +
> > + fsl,drive-strength:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [0, 1, 2, 3]
> > + description: |
> > + 0: MXS_DRIVE_4mA
> > + 1: MXS_DRIVE_8mA
> > + 2: MXS_DRIVE_12mA
> > + 3: MXS_DRIVE_16mA
> > +
> > + fsl,voltage:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [0, 1]
> > + description: |
> > + 0: MXS_VOLTAGE_LOW - 1.8 V
> > + 1: MXS_VOLTAGE_HIGH - 3.3 V
> > +
> > + fsl,pull-up:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [0, 1]
> > + description: |
> > + 0: MXS_PULL_DISABLE - Disable the internal pull-up
> > + 1: MXS_PULL_ENABLE - Enable the internal pull-up
> > +
> > + Note that when enabling the pull-up, the internal pad keeper gets disabled.
> > + Also, some pins doesn't have a pull up, in that case, setting the fsl,pull-up
> > + will only disable the internal pad keeper.
> > +
> > + required:
> > + - fsl,pinmux-ids
> > +
> > + additionalProperties: false
> > +
> > "gpio@[0-9]+$":
> > type: object
> > properties:
> > @@ -80,7 +137,7 @@ examples:
> > pinctrl@...18000 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > - compatible = "fsl,imx28-pinctrl";
> > + compatible = "fsl,imx28-pinctrl", "simple-bus";
> > reg = <0x80018000 0x2000>;
> >
> > gpio@0 {
> > @@ -132,4 +189,12 @@ examples:
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > };
> > +
> > + lcdif-apx4@5 {
> > + reg = <5>;
> > + fsl,pinmux-ids = <0x1181 0x1191>;
> > + fsl,drive-strength = <0>;
> > + fsl,voltage = <0>;
> > + fsl,pull-up = <0>;
> > + };
> > };
Powered by blists - more mailing lists