linux-kernel - Re: [PATCH v2 1/4] mm: ksm: have KSM VMA checks not require a VMA pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505282341166875usqhF9LuBlmx70Sd33jP@zte.com.cn>
Date: Wed, 28 May 2025 23:41:16 +0800 (CST)
From: <xu.xin16@....com.cn>
To: <lorenzo.stoakes@...cle.com>
Cc: <akpm@...ux-foundation.org>, <viro@...iv.linux.org.uk>,
        <brauner@...nel.org>, <jack@...e.cz>, <Liam.Howlett@...cle.com>,
        <vbabka@...e.cz>, <jannh@...gle.com>, <pfalcato@...e.de>,
        <david@...hat.com>, <chengming.zhou@...ux.dev>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <shr@...kernel.io>, <wang.yaxin@....com.cn>, <yang.yang29@....com.cn>
Subject: Re: [PATCH v2 1/4] mm: ksm: have KSM VMA checks not require a VMA pointer

> In subsequent commits we are going to determine KSM eligibility prior to a
> VMA being constructed, at which point we will of course not yet have access
> to a VMA pointer.
> 
> It is trivial to boil down the check logic to be parameterised on
> mm_struct, file and VMA flags, so do so.
> 
> As a part of this change, additionally expose and use file_is_dax() to
> determine whether a file is being mapped under a DAX inode.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> Acked-by: David Hildenbrand <david@...hat.com>
> Reviewed-by: Chengming Zhou <chengming.zhou@...ux.dev>
> ---
>  include/linux/fs.h |  7 ++++++-
>  mm/ksm.c           | 32 ++++++++++++++++++++------------
>  2 files changed, 26 insertions(+), 13 deletions(-)

All looks good to me.

Reviewed-by: Xu Xin <xu.xin16@....com.cn>