linux-kernel - Re: [PATCH net-next] selftest: Add selftest for multicast address notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250528154906.GD1484967@horms.kernel.org>
Date: Wed, 28 May 2025 16:49:06 +0100
From: Simon Horman <horms@...nel.org>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	Maciej Żenczykowski <maze@...gle.com>,
	Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net-next] selftest: Add selftest for multicast address
 notifications

On Tue, May 27, 2025 at 06:18:55PM +0900, Yuyang Huang wrote:
> This commit adds a new kernel selftest to verify RTNLGRP_IPV4_MCADDR
> and RTNLGRP_IPV6_MCADDR notifications. The test works by adding and
> removing a dummy interface and then confirming that the system
> correctly receives join and removal notifications for the 224.0.0.1
> and ff02::1 multicast addresses.
> 
> The test relies on the iproute2 version to be 6.13+.
> 
> Tested by the following command:
> $ vng -v --user root --cpus 16 -- \
> make -C tools/testing/selftests TARGETS=net TEST_PROGS=rtnetlink.sh \
> TEST_GEN_PROGS="" run_tests
> 
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Lorenzo Colitti <lorenzo@...gle.com>
> Signed-off-by: Yuyang Huang <yuyanghuang@...gle.com>

...

> +kci_test_mcast_addr_notification()
> +{
> +	local tmpfile
> +	local monitor_pid
> +	local match_result
> +
> +	tmpfile=$(mktemp)
> +
> +	ip monitor maddr > $tmpfile &
> +	monitor_pid=$!

Hi Yuyang Huang,

Other tests in this file seem to warn if the ip command is too old
to support the test. Perhaps we can achieve that here something like this
(completely untested!):

	if [ ! -e "/proc/$monitor_pid" ]; then
		end_test "SKIP: mcast addr notification: iproute2 too old"
		rm $tmpfile
		return $ksft_skip
	fi

> +	sleep 1
> +
> +	run_cmd ip link add name test-dummy1 type dummy
> +	run_cmd ip link set test-dummy1 up
> +	run_cmd ip link del dev test-dummy1
> +	sleep 1
> +
> +	match_result=$(grep -cE "test-dummy1.*(224.0.0.1|ff02::1)" $tmpfile)
> +
> +	kill $monitor_pid
> +	rm $tmpfile
> +	# There should be 4 line matches as follows.
> +	# 13: test-dummy1    inet6 mcast ff02::1 scope global 
> +	# 13: test-dummy1    inet mcast 224.0.0.1 scope global 
> +	# Deleted 13: test-dummy1    inet mcast 224.0.0.1 scope global 
> +	# Deleted 13: test-dummy1    inet6 mcast ff02::1 scope global 
> +	if [ $match_result -ne 4 ];then
> +		end_test "FAIL: mcast addr notification"
> +		return 1
> +	fi
> +	end_test "PASS: mcast addr notification"
> +}
> +

...

## Form letter - net-next-closed

The merge window for v6.16 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations. We are
currently accepting bug fixes only.

Please repost when net-next reopens after June 8th.

RFC patches sent for review only are obviously welcome at any time.

pw-bot: deffer