linux-kernel - Re: [PATCH v2 16/16] mt76: use netmem descriptor and APIs for page pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505282311.lZqpYSc9-lkp@intel.com>
Date: Wed, 28 May 2025 23:57:45 +0800
From: kernel test robot <lkp@...el.com>
To: Byungchul Park <byungchul@...com>, willy@...radead.org,
	netdev@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	kernel_team@...ynix.com, kuba@...nel.org, almasrymina@...gle.com,
	ilias.apalodimas@...aro.org, harry.yoo@...cle.com, hawk@...nel.org,
	akpm@...ux-foundation.org, davem@...emloft.net,
	john.fastabend@...il.com, andrew+netdev@...n.ch,
	asml.silence@...il.com, toke@...hat.com, tariqt@...dia.com,
	edumazet@...gle.com, pabeni@...hat.com, saeedm@...dia.com,
	leon@...nel.org, ast@...nel.org, daniel@...earbox.net,
	david@...hat.com, lorenzo.stoakes@...cle.com,
	Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org,
	surenb@...gle.com, mhocko@...e.com
Subject: Re: [PATCH v2 16/16] mt76: use netmem descriptor and APIs for page
 pool

Hi Byungchul,

kernel test robot noticed the following build errors:

[auto build test ERROR on d09a8a4ab57849d0401d7c0bc6583e367984d9f7]

url:    https://github.com/intel-lab-lkp/linux/commits/Byungchul-Park/netmem-introduce-struct-netmem_desc-struct_group_tagged-ed-on-struct-net_iov/20250528-103136
base:   d09a8a4ab57849d0401d7c0bc6583e367984d9f7
patch link:    https://lore.kernel.org/r/20250528022911.73453-17-byungchul%40sk.com
patch subject: [PATCH v2 16/16] mt76: use netmem descriptor and APIs for page pool
config: i386-buildonly-randconfig-004-20250528 (https://download.01.org/0day-ci/archive/20250528/202505282311.lZqpYSc9-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250528/202505282311.lZqpYSc9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505282311.lZqpYSc9-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/sdio_txrx.c:74:3: error: must use 'struct' tag to refer to type 'page'
      74 |                 page = netmem_compound_head(virt_to_netmem(data));
         |                 ^
         |                 struct 
>> drivers/net/wireless/mediatek/mt76/sdio_txrx.c:74:8: error: expected identifier or '('
      74 |                 page = netmem_compound_head(virt_to_netmem(data));
         |                      ^
   2 errors generated.


vim +74 drivers/net/wireless/mediatek/mt76/sdio_txrx.c

    58	
    59	static struct sk_buff *
    60	mt76s_build_rx_skb(void *data, int data_len, int buf_len)
    61	{
    62		int len = min_t(int, data_len, MT_SKB_HEAD_LEN);
    63		struct sk_buff *skb;
    64	
    65		skb = alloc_skb(len, GFP_KERNEL);
    66		if (!skb)
    67			return NULL;
    68	
    69		skb_put_data(skb, data, len);
    70		if (data_len > len) {
    71			netmem_ref netmem;
    72	
    73			data += len;
  > 74			page = netmem_compound_head(virt_to_netmem(data));
    75			skb_add_rx_frag_netmem(skb, skb_shinfo(skb)->nr_frags,
    76					       netmem, data - netmem_address(netmem),
    77					       data_len - len, buf_len);
    78			get_netmem(netmem);
    79		}
    80	
    81		return skb;
    82	}
    83	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki