linux-kernel - Re: [PATCH] rust: add helper for mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fadc8e044c3b18984b0ca4a88ef214feb779034d.camel@redhat.com>
Date: Wed, 28 May 2025 12:08:23 -0400
From: mlevitsk@...hat.com
To: Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org, 
	kvm@...r.kernel.org
Cc: rust-for-linux@...r.kernel.org, ojeda@...nel.org, Stephen Rothwell
	 <sfr@...b.auug.org.au>
Subject: Re: [PATCH] rust: add helper for mutex_trylock

On Wed, 2025-05-28 at 10:34 +0200, Paolo Bonzini wrote:
> After commit c5b6ababd21a ("locking/mutex: implement mutex_trylock_nested",
> currently in the KVM tree) mutex_trylock() will be a macro when lockdep is
> enabled.  Rust therefore needs the corresponding helper.  Just add it and
> the rust/bindings/bindings_helpers_generated.rs Makefile rules will do
> their thing.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>


Hi,
Sorry for that. 

Next time I'll check rust bindings as well, I never had to deal with them before.

Reviewed-by: Maxim Levitsky <mlevitsk@...hat.com>

Best regards,
	Maxim Levitsky


> ---
>         Ok to apply to the KVM tree?
> 
>  rust/helpers/mutex.c                               |   5 +++++
>  1 files changed, 5 insertions(+)
> 
> diff a/rust/helpers/mutex.c b/rust/helpers/mutex.c
> index 06575553eda5,06575553eda5..9ab29104bee1
> --- a/rust/helpers/mutex.c
> +++ b/rust/helpers/mutex.c
> @@ -7,6 +7,11 @@ void rust_helper_mutex_lock(struct mute
>  	mutex_lock(lock);
>  }
>  
> +int rust_helper_mutex_trylock(struct mutex *lock)
> +{
> +	return mutex_trylock(lock);
> +}
> +
>  void rust_helper___mutex_init(struct mutex *mutex, const char *name,
>  			      struct lock_class_key *key)
>  {
> 
>