linux-kernel - Re: [PATCH net] net: ti: icssg-prueth: Fix swapped TX stats for MII interfaces.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250528161250.GE1484967@horms.kernel.org>
Date: Wed, 28 May 2025 17:12:50 +0100
From: Simon Horman <horms@...nel.org>
To: Meghana Malladi <m-malladi@...com>
Cc: saikrishnag@...vell.com, pabeni@...hat.com, kuba@...nel.org,
	edumazet@...gle.com, davem@...emloft.net, andrew+netdev@...n.ch,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, srk@...com,
	Vignesh Raghavendra <vigneshr@...com>,
	Roger Quadros <rogerq@...nel.org>, danishanwar@...com
Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix swapped TX stats for MII
 interfaces.

On Tue, May 27, 2025 at 05:43:25PM +0530, Meghana Malladi wrote:
> In MII mode, Tx lines are swapped for port0 and port1, which means
> Tx port0 receives data from PRU1 and the Tx port1 receives data from
> PRU0. This is an expected hardware behavior and reading the Tx stats
> needs to be handled accordingly in the driver. Update the driver to
> read Tx stats from the PRU1 for port0 and PRU0 for port1.
> 
> Fixes: c1e10d5dc7a1 ("net: ti: icssg-prueth: Add ICSSG Stats")
> Signed-off-by: Meghana Malladi <m-malladi@...com>
> ---
>  drivers/net/ethernet/ti/icssg/icssg_stats.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_stats.c b/drivers/net/ethernet/ti/icssg/icssg_stats.c
> index 6f0edae38ea2..0b77930b2f08 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_stats.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_stats.c
> @@ -29,6 +29,10 @@ void emac_update_hardware_stats(struct prueth_emac *emac)
>  	spin_lock(&prueth->stats_lock);
>  
>  	for (i = 0; i < ARRAY_SIZE(icssg_all_miig_stats); i++) {

Hi Meghana,

Perhaps it would be nice to include a comment here.

> +		if (emac->phy_if == PHY_INTERFACE_MODE_MII &&
> +		    icssg_all_miig_stats[i].offset >= ICSSG_TX_PACKET_OFFSET &&
> +		    icssg_all_miig_stats[i].offset <= ICSSG_TX_BYTE_OFFSET)
> +			base = stats_base[slice ^ 1];
>  		regmap_read(prueth->miig_rt,
>  			    base + icssg_all_miig_stats[i].offset,
>  			    &val);
> 
> base-commit: 32374234ab0101881e7d0c6a8ef7ebce566c46c9
> -- 
> 2.43.0
> 
>