linux-kernel - Re: [PATCH v5 01/29] iommufd: Apply obvious cosmetic fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250528165526.GU61950@nvidia.com>
Date: Wed, 28 May 2025 13:55:26 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, corbet@....net, will@...nel.org,
	bagasdotme@...il.com, robin.murphy@....com, joro@...tes.org,
	thierry.reding@...il.com, vdumpa@...dia.com, jonathanh@...dia.com,
	shuah@...nel.org, jsnitsel@...hat.com, nathan@...nel.org,
	peterz@...radead.org, yi.l.liu@...el.com, mshavit@...gle.com,
	praan@...gle.com, zhangzekun11@...wei.com, iommu@...ts.linux.dev,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
	linux-kselftest@...r.kernel.org, patches@...ts.linux.dev,
	mochs@...dia.com, alok.a.tiwari@...cle.com, vasant.hegde@....com,
	dwmw2@...radead.org, baolu.lu@...ux.intel.com
Subject: Re: [PATCH v5 01/29] iommufd: Apply obvious cosmetic fixes

On Sat, May 17, 2025 at 08:21:18PM -0700, Nicolin Chen wrote:
> Run clang-format but exclude those not so obvious ones, which leaves us:
>  - Align indentations
>  - Add missing spaces
>  - Remove unnecessary spaces
>  - Remove unnecessary line wrappings
> 
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/iommu/iommufd/io_pagetable.h    |  2 +-
>  drivers/iommu/iommufd/iommufd_private.h |  6 ++----
>  include/linux/iommufd.h                 |  5 +++--
>  drivers/iommu/iommufd/device.c          |  3 +--
>  drivers/iommu/iommufd/hw_pagetable.c    |  6 ++----
>  drivers/iommu/iommufd/io_pagetable.c    |  3 +--
>  drivers/iommu/iommufd/iova_bitmap.c     |  1 -
>  drivers/iommu/iommufd/main.c            |  6 ++----
>  drivers/iommu/iommufd/pages.c           |  9 ++++-----
>  drivers/iommu/iommufd/selftest.c        | 24 +++++++++++-------------
>  10 files changed, 27 insertions(+), 38 deletions(-)

I have mixed feelings, I know people don't like churn, but it doesn't
seem so bad..

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason