Message-ID:
 <DS7PR19MB8883581EF8CD829910D3C1C29D67A@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Wed, 28 May 2025 20:59:45 +0400
From: George Moussalem <george.moussalem@...look.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
 Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, linux-clk@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
 Stephen Boyd <sboyd@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Heiner Kallweit <hkallweit1@...il.com>, Conor Dooley <conor+dt@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v2 2/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal
 GE PHY support

Hi Rob,

On 5/28/25 20:30, Rob Herring (Arm) wrote:
> 
> On Wed, 28 May 2025 18:45:48 +0400, George Moussalem wrote:
>> Document the IPQ5018 Internal Gigabit Ethernet PHY found in the IPQ5018
>> SoC. Its output pins provide an MDI interface to either an external
>> switch in a PHY to PHY link scenario or is directly attached to an RJ45
>> connector.
>>
>> The PHY supports 10/100/1000 mbps link modes, CDT, auto-negotiation and
>> 802.3az EEE.
>>
>> For operation, the LDO controller found in the IPQ5018 SoC for which
>> there is provision in the mdio-4019 driver. In addition, the PHY needs
>> to take itself out of reset and enable the RX and TX clocks.
>>
>> Two common archictures across IPQ5018 boards are:
>> 1. IPQ5018 PHY --> MDI --> RJ45 connector
>> 2. IPQ5018 PHY --> MDI --> External PHY
>> In a phy to phy architecture, DAC values need to be set to accommodate
>> for the short cable length. As such, add an optional boolean property so
>> the driver sets the correct register values for the DAC accordingly.
>>
>> Signed-off-by: George Moussalem <george.moussalem@...look.com>
>> ---
>>   .../devicetree/bindings/net/qca,ar803x.yaml        | 52 +++++++++++++++++++++-
>>   1 file changed, 51 insertions(+), 1 deletion(-)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/qca,ar803x.example.dtb: ethernet-phy@7 (ethernet-phy-id004d.d0c0): clocks: [[4294967295, 36], [4294967295, 37]] is too long
> 	from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250528-ipq5018-ge-phy-v2-2-dd063674c71c@outlook.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 


Really weird, I've checked this numerous times:

(myenv) george@...-ubuntu:~/src/linux-next$ make dt_binding_check 
DT_SCHEMA_FILES=qca,ar803x.yaml
   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
   CHKDT   ./Documentation/devicetree/bindings
   LINT    ./Documentation/devicetree/bindings
   DTEX    Documentation/devicetree/bindings/net/qca,ar803x.example.dts
   DTC [C] Documentation/devicetree/bindings/net/qca,ar803x.example.dtb
(myenv) george@...-ubuntu:~/src/linux-next$ pip3 install dtschema --upgrade
Requirement already satisfied: dtschema in 
/home/george/myenv/lib/python3.12/site-packages (2025.2)
Requirement already satisfied: ruamel.yaml>0.15.69 in 
/home/george/myenv/lib/python3.12/site-packages (from dtschema) (0.18.10)
Requirement already satisfied: jsonschema<4.18,>=4.1.2 in 
/home/george/myenv/lib/python3.12/site-packages (from dtschema) (4.17.3)
Requirement already satisfied: rfc3987 in 
/home/george/myenv/lib/python3.12/site-packages (from dtschema) (1.3.8)
Requirement already satisfied: pylibfdt in 
/home/george/myenv/lib/python3.12/site-packages (from dtschema) (1.7.2)
Requirement already satisfied: attrs>=17.4.0 in 
/home/george/myenv/lib/python3.12/site-packages (from 
jsonschema<4.18,>=4.1.2->dtschema) (25.3.0)
Requirement already satisfied: 
pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in 
/home/george/myenv/lib/python3.12/site-packages (from 
jsonschema<4.18,>=4.1.2->dtschema) (0.20.0)
Requirement already satisfied: ruamel.yaml.clib>=0.2.7 in 
/home/george/myenv/lib/python3.12/site-packages (from 
ruamel.yaml>0.15.69->dtschema) (0.2.12)
(myenv) george@...-ubuntu:~/src/linux-next$ make dt_binding_check 
DT_SCHEMA_FILES=qca,ar803x.yaml
   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
   CHKDT   ./Documentation/devicetree/bindings
   LINT    ./Documentation/devicetree/bindings
   DTEX    Documentation/devicetree/bindings/net/qca,ar803x.example.dts
   DTC [C] Documentation/devicetree/bindings/net/qca,ar803x.example.dtb

I only found the same errors when removing the DT_SCHEMA_FILES property.
Is that because ethernet-phy.yaml is a catch-all based on the pattern on 
the compatible property (assuming my understanding is correct)? How 
would we get around that without modifying ethernet-phy.yaml only for 
this particular PHY (with a condition)? This PHY needs to enable two 
clocks and the restriction is on 1.

Your guidance would be appreciated.

Best regards,
George

Powered by blists - more mailing lists