linux-kernel - Re: [Patch v2] perf tools: Fix incorrect --user-regs comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDdDt9O1O4gky_st@x1>
Date: Wed, 28 May 2025 14:11:19 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dapeng Mi <dapeng1.mi@...el.com>
Subject: Re: [Patch v2] perf tools: Fix incorrect --user-regs comments

On Wed, May 28, 2025 at 03:03:13PM +0800, Mi, Dapeng wrote:
> Kindly ping... Thanks.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> On 4/3/2025 2:08 PM, Dapeng Mi wrote:
> > The comment of "--user-regs" option is not correct, fix it.
> >
> > "on interrupt," -> "in user space,"
> >
> > Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
> > Signed-off-by: Dapeng Mi <dapeng1.mi@...ux.intel.com>
> > Reviewed-by: Ian Rogers <irogers@...gle.com>
> > ---
> >  tools/perf/builtin-record.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index ba20bf7c011d..d56273a0e241 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
> >  		    "sample selected machine registers on interrupt,"
> >  		    " use '-I?' to list register names", parse_intr_regs),
> >  	OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
> > -		    "sample selected machine registers on interrupt,"
> > +		    "sample selected machine registers in user space,"
> >  		    " use '--user-regs=?' to list register names", parse_user_regs),
> >  	OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
> >  		    "Record running/enabled time of read (:S) events"),
> >
> > base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc