linux-kernel - Re: [PATCH 14/17] pinctrl: renesas: Move fixed assignments to 'pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6b7fb61-878e-4407-b964-564efb3524b1@linaro.org>
Date: Wed, 28 May 2025 19:55:07 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
 Basavaraj Natikar <Basavaraj.Natikar@....com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Andrew Jeffery <andrew@...econstruct.com.au>, Joel Stanley <joel@....id.au>,
 Avi Fishman <avifishman70@...il.com>, Tomer Maimon <tmaimon77@...il.com>,
 Tali Perry <tali.perry1@...il.com>, Patrick Venture <venture@...gle.com>,
 Nancy Yuen <yuenn@...gle.com>, Benjamin Fair <benjaminfair@...gle.com>,
 Jonathan Neuschäfer <j.neuschaefer@....net>,
 Rafał Miłecki <rafal@...ecki.pl>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 David Rhodes <david.rhodes@...rus.com>,
 Richard Fitzgerald <rf@...nsource.cirrus.com>,
 Charles Keepax <ckeepax@...nsource.cirrus.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Sean Wang <sean.wang@...nel.org>,
 Jesper Nilsson <jesper.nilsson@...s.com>,
 Lars Persson <lars.persson@...s.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Damien Le Moal <dlemoal@...nel.org>, Vladimir Zapolskiy <vz@...ia.com>,
 Michal Simek <michal.simek@....com>, Emil Renner Berthing <kernel@...il.dk>,
 Jianlong Huang <jianlong.huang@...rfivetech.com>,
 Hal Feng <hal.feng@...rfivetech.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
 openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 linux-renesas-soc@...r.kernel.org, linux-sound@...r.kernel.org,
 patches@...nsource.cirrus.com, linux-mediatek@...ts.infradead.org,
 linux-arm-kernel@...s.com, linux-riscv@...ts.infradead.org,
 linux-rtc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 14/17] pinctrl: renesas: Move fixed assignments to
 'pinctrl_desc' definition

On 28/05/2025 14:54, Geert Uytterhoeven wrote:
>>         .pmxops = &rzn1_pmx_ops,
>>         .confops = &rzn1_pinconf_ops,
>>         .owner = THIS_MODULE,
>> +       .pins = rzn1_pins,
>> +       .npins = ARRAY_SIZE(rzn1_pins),
>>  };
>>
>>  static int rzn1_pinctrl_parse_groups(struct device_node *np,
>> @@ -878,8 +880,6 @@ static int rzn1_pinctrl_probe(struct platform_device *pdev)
>>
>>         ipctl->dev = &pdev->dev;
>>         rzn1_pinctrl_desc.name = dev_name(&pdev->dev);
> 
> ... if you would replace this assignment by a hardcoded name
> like "pinctrl-rzn1".

I saw it, but this would not be equivalent. dev_name includes platform
bus id, e.g. pinctrl-rzn1.0 which might matter here - conflict of names.
Are you sure this would work fine?

Best regards,
Krzysztof