linux-kernel - Re: [PATCH 0/2] nfsd: use threads array as-is in netlink thread set interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <298ef5505e7abb9a0ca5f151090a42f8bf330c43.camel@kernel.org>
Date: Wed, 28 May 2025 14:22:51 -0400
From: Jeff Layton <jlayton@...nel.org>
To: cel@...nel.org, Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo	
 <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, Steven Rostedt	
 <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Trond Myklebust
 <trondmy@...nel.org>, Anna Schumaker	 <anna@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet	 <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni	 <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, NeilBrown <neil@...wn.name>
Cc: Chuck Lever <chuck.lever@...cle.com>, Mike Snitzer <snitzer@...nel.org>,
 	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] nfsd: use threads array as-is in netlink thread set
 interface

On Wed, 2025-05-28 at 14:11 -0400, cel@...nel.org wrote:
> From: Chuck Lever <chuck.lever@...cle.com>
> 
> On Tue, 27 May 2025 20:12:46 -0400, Jeff Layton wrote:
> > The first patch is probably appropriate for stable. It should fix
> > problems when someone sets the pool_mode to pernode, without userland
> > sending down a fully-populated thread array.
> > 
> > The second patch just adds a couple of new tracepoints that I ended up
> > using to track this down.
> > 
> > [...]
> 
> Applied to nfsd-testing, thanks!
> 
> [1/2] nfsd: use threads array as-is in netlink interface
>       commit: b2a9a114a3c7f5abfa2875b70ce9b73525a74291
> [2/2] sunrpc: new tracepoints around svc thread wakeups
>       commit: 65b8babe551bddf00aac69bc905f88a4e0371766
> 

My apologies, Chuck. Patch #2 has a bug in it:

+       trace_svc_pool_thread_noidle(pool, rqstp->rq_task->pid);

In the call above, the rqstp will be undefined. That should be:

+       trace_svc_pool_thread_noidle(pool, 0);

You can fix that up in tree, or I can resend if you prefer.

Thanks!
-- 
Jeff Layton <jlayton@...nel.org>