linux-kernel - Re: [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this out of CI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250528184122.GA1002333@google.com>
Date: Wed, 28 May 2025 18:41:22 +0000
From: Eric Biggers <ebiggers@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: Justin Stitt <justinstitt@...gle.com>, Arnd Bergmann <arnd@...db.de>,
	Jann Horn <jannh@...gle.com>, Marco Elver <elver@...gle.com>,
	llvm@...ts.linux.dev, linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this
 out of CI

On Wed, May 28, 2025 at 11:26:22AM -0700, Kees Cook wrote:
> Depending on !COMPILE_TEST isn't sufficient to keep this feature out of
> CI because we can't stop it from being included in randconfig builds.
> This feature is still highly experimental, and is developed in lock-step
> with Clang's Overflow Behavior Types[1]. Depend on BROKEN to keep it
> from being enabled by anyone not expecting it.
> 
> Link: https://discourse.llvm.org/t/rfc-v2-clang-introduce-overflowbehaviortypes-for-wrapping-and-non-wrapping-arithmetic/86507 [1]
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Justin Stitt <justinstitt@...gle.com>
> Cc: Eric Biggers <ebiggers@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Jann Horn <jannh@...gle.com>
> Cc: Marco Elver <elver@...gle.com>
> Cc: llvm@...ts.linux.dev
> Cc: <linux-hardening@...r.kernel.org>
> ---
>  lib/Kconfig.ubsan | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan
> index f6ea0c5b5da3..96cd89668467 100644
> --- a/lib/Kconfig.ubsan
> +++ b/lib/Kconfig.ubsan
> @@ -118,6 +118,8 @@ config UBSAN_UNREACHABLE
>  
>  config UBSAN_INTEGER_WRAP
>  	bool "Perform checking for integer arithmetic wrap-around"
> +	# This is very experimental so drop the next line if you really want it
> +	depends on BROKEN
>  	depends on !COMPILE_TEST
>  	depends on $(cc-option,-fsanitize-undefined-ignore-overflow-pattern=all)
>  	depends on $(cc-option,-fsanitize=signed-integer-overflow)
> -- 

Acked-by: Eric Biggers <ebiggers@...nel.org>

- Eric