linux-kernel - Re: [PATCH 1/1] dt-bindings: mtd: jedec,spi-nor: Add atmel,at26* compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mafs0tt54r2ao.fsf@kernel.org>
Date: Wed, 28 May 2025 20:57:35 +0200
From: Pratyush Yadav <pratyush@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Pratyush Yadav <pratyush@...nel.org>,  Tudor Ambarus
 <tudor.ambarus@...aro.org>,  Michael Walle <mwalle@...nel.org>,  Miquel
 Raynal <miquel.raynal@...tlin.com>,  Richard Weinberger <richard@....at>,
  Vignesh Raghavendra <vigneshr@...com>,  Rob Herring <robh@...nel.org>,
  Krzysztof Kozlowski <krzk+dt@...nel.org>,  Conor Dooley
 <conor+dt@...nel.org>,  "open list:SPI NOR SUBSYSTEM"
 <linux-mtd@...ts.infradead.org>,  "open list:OPEN FIRMWARE AND FLATTENED
 DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,  open list
 <linux-kernel@...r.kernel.org>,  imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: mtd: jedec,spi-nor: Add atmel,at26*
 compatible string

On Wed, May 28 2025, Frank Li wrote:

> On Tue, May 27, 2025 at 06:13:22PM +0200, Pratyush Yadav wrote:
>> On Fri, May 23 2025, Frank Li wrote:
>>
>> > Add atmel,at26* compatible string to fix below CHECK_DTB warning:
>> >
>> > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@...00000/spi@...2c000/at26df081a@0:
>> >     failed to match any schema with compatible: ['atmel,at26df081a']
>>
>> Is there any problem with setting the compatible to "jedec,spi-nor" in
>> the DTS instead? If not, it would better to do that instead.
>
> I suppose it should work. But it is quite old legancy boards. I have not
> board to test it.  And dt also prefer add chip specific compatible string
> before common failback compatible string in case need workaround some chip
> issues.

Hmm, poking around with old DTs is probably not a good idea. Anyway, the
flash is listed in spi_nor_dev_ids just like the others in this yaml, so
this patch looks fine.

Acked-by: Pratyush Yadav <pratyush@...nel.org>

-- 
Regards,
Pratyush Yadav