linux-kernel - Re: [PATCH v8] staging: rtl8723bs: rename _Read_EEPROM and other functions to snake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250528211533.DIM_zxnE@linutronix.de>
Date: Wed, 28 May 2025 23:15:33 +0200
From: Nam Cao <namcao@...utronix.de>
To: Donny Turizo <donnyturizo13@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8] staging: rtl8723bs: rename _Read_EEPROM and other
 functions to snake_case

On Tue, May 27, 2025 at 12:43:27AM +0000, Donny Turizo wrote:
> Renamed _Read_EEPROM and several other functions in rtw_cmd.c to follow
> the kernel coding style (snake_case). This fixes checkpatch warnings
> related to naming conventions.
> 
> Signed-off-by: Donny Turizo <donnyturizo13@...il.com>
> 
> ---
> v8:
> Actually rebased on top of the latest gregkh/staging-testing.
> In v7 I mentioned a rebase, but I had forgotten to run
> `git fetch gregkh`, so the patch was not properly rebased.
> No code changes from v7. Only the base of the patch is updated.

I still cannot apply the patch. Are you sure you rebased correctly? You
mentioned that the patch didn't change, so I think no :(

I couldn't apply it to verify the build, but I seriously doubt that this
patch doesn't break the build. Are you sure you built the driver? Make sure
you have CONFIG_RTL8723BS=y in your .config file. Also double check that
there is a drivers/staging/rtl8723bs/core/rtw_cmd.o object file after the
build.

Best regards,
Nam