linux-kernel - Re: [PATCH 2/2] mm/damon/sysfs-schemes: add use_nodes_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505290538.2zlscryI-lkp@intel.com>
Date: Thu, 29 May 2025 05:33:18 +0800
From: kernel test robot <lkp@...el.com>
To: wangchuanguo <wangchuanguo@...pur.com>, akpm@...ux-foundation.org,
	hannes@...xchg.org, sj@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, david@...hat.com, mhocko@...nel.org,
	zhengqi.arch@...edance.com, shakeel.butt@...ux.dev,
	lorenzo.stoakes@...cle.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, damon@...ts.linux.dev,
	wangchuanguo <wangchuanguo@...pur.com>
Subject: Re: [PATCH 2/2] mm/damon/sysfs-schemes: add use_nodes_of_tier on
 sysfs-schemes

Hi wangchuanguo,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on sj/damon/next next-20250528]
[cannot apply to linus/master v6.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/wangchuanguo/mm-migrate-restore-the-nmask-after-successfully-allocating-on-the-target-node/20250528-191141
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20250528111038.18378-3-wangchuanguo%40inspur.com
patch subject: [PATCH 2/2] mm/damon/sysfs-schemes: add use_nodes_of_tier on sysfs-schemes
config: arc-randconfig-002-20250529 (https://download.01.org/0day-ci/archive/20250529/202505290538.2zlscryI-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250529/202505290538.2zlscryI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505290538.2zlscryI-lkp@intel.com/

All errors (new ones prefixed by >>):

   mm/damon/paddr.c: In function '__damon_pa_migrate_folio_list':
>> mm/damon/paddr.c:409:18: error: implicit declaration of function 'get_tier_nodemask'; did you mean 'set_user_sigmask'? [-Werror=implicit-function-declaration]
      allowed_mask = get_tier_nodemask(target_nid);
                     ^~~~~~~~~~~~~~~~~
                     set_user_sigmask
>> mm/damon/paddr.c:409:16: error: incompatible types when assigning to type 'nodemask_t' {aka 'struct <anonymous>'} from type 'int'
      allowed_mask = get_tier_nodemask(target_nid);
                   ^
   cc1: some warnings being treated as errors


vim +409 mm/damon/paddr.c

   383	
   384	static unsigned int __damon_pa_migrate_folio_list(
   385			struct list_head *migrate_folios, struct pglist_data *pgdat,
   386			int target_nid, bool use_nodes_of_tier)
   387	{
   388		unsigned int nr_succeeded = 0;
   389		nodemask_t allowed_mask = NODE_MASK_NONE;
   390		struct migration_target_control mtc = {
   391			/*
   392			 * Allocate from 'node', or fail quickly and quietly.
   393			 * When this happens, 'page' will likely just be discarded
   394			 * instead of migrated.
   395			 */
   396			.gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
   397				__GFP_NOWARN | __GFP_NOMEMALLOC | GFP_NOWAIT,
   398			.nid = target_nid,
   399			.nmask = &allowed_mask
   400		};
   401	
   402		if (pgdat->node_id == target_nid || target_nid == NUMA_NO_NODE)
   403			return 0;
   404	
   405		if (list_empty(migrate_folios))
   406			return 0;
   407	
   408		if (use_nodes_of_tier)
 > 409			allowed_mask = get_tier_nodemask(target_nid);
   410	
   411		/* Migration ignores all cpuset and mempolicy settings */
   412		migrate_pages(migrate_folios, alloc_migrate_folio, NULL,
   413			      (unsigned long)&mtc, MIGRATE_ASYNC, MR_DAMON,
   414			      &nr_succeeded);
   415	
   416		return nr_succeeded;
   417	}
   418	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki