linux-kernel - Re: [PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250528223915.55694-1-sj@kernel.org>
Date: Wed, 28 May 2025 15:39:15 -0700
From: SeongJae Park <sj@...nel.org>
To: wangchuanguo <wangchuanguo@...pur.com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	hannes@...xchg.org,
	david@...hat.com,
	mhocko@...nel.org,
	zhengqi.arch@...edance.com,
	shakeel.butt@...ux.dev,
	lorenzo.stoakes@...cle.com,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	damon@...ts.linux.dev
Subject: Re: [PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON

Hi wangchuanguo,


Thank you for sending this patch series!

On Wed, 28 May 2025 19:10:36 +0800 wangchuanguo <wangchuanguo@...pur.com> wrote:

> In DAMON's migrate_hot and migrate_cold features, the code was
> intended to migrate pages only to the node specified by target_nid.
> However, during testing, it was observed that memory allocation
> and migration could occur on any nodes, which is a BUG.
> The first patch in this PR fix this issue.
> 
> A use_nodes_of_tier file has been added under the directory /sys/kernel/mm/damon/admin/kdamonds/<N>/contexts/<N>/schemes/<N>/
> to control whether to use other nodes in the same tier as
> the target node for migration.

I left a few comments on the patches.  Looking forward to discussions on each
sub-thread :)

> 
> wangchuanguo (2):

I believe your name is Wang Chuanguo?  Sorry if I read/wrote it wrongly.  But
we disallow[1] anonymous contributions, and prefer more formal Signed-off-by:
if possible.  Could you please use such formal Signed-off-by: identity, say,
"Wang Chuanguo <wangchuanguo@...pur.com>" from next time?

[1] https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1


Thanks,
SJ

[...]