linux-kernel - Re: [PATCH] ring-buffer: Simplify reset_disabled_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250528093005.486a6fdbaae7976430680baf@kernel.org>
Date: Wed, 28 May 2025 09:30:05 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] ring-buffer: Simplify reset_disabled_cpu_buffer() with
 use of guard()

On Tue, 27 May 2025 14:46:23 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Steven Rostedt <rostedt@...dmis.org>
> 
> Use guard(raw_spinlock_irqsave)() in reset_disabled_cpu_buffer() to
> simplify the locking.
> 

Looks good to me.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  kernel/trace/ring_buffer.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 10a4b26929ae..0b21d64e90c8 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -6112,21 +6112,16 @@ rb_reset_cpu(struct ring_buffer_per_cpu *cpu_buffer)
>  /* Must have disabled the cpu buffer then done a synchronize_rcu */
>  static void reset_disabled_cpu_buffer(struct ring_buffer_per_cpu *cpu_buffer)
>  {
> -	unsigned long flags;
> -
> -	raw_spin_lock_irqsave(&cpu_buffer->reader_lock, flags);
> +	guard(raw_spinlock_irqsave)(&cpu_buffer->reader_lock);
>  
>  	if (RB_WARN_ON(cpu_buffer, local_read(&cpu_buffer->committing)))
> -		goto out;
> +		return;
>  
>  	arch_spin_lock(&cpu_buffer->lock);
>  
>  	rb_reset_cpu(cpu_buffer);
>  
>  	arch_spin_unlock(&cpu_buffer->lock);
> -
> - out:
> -	raw_spin_unlock_irqrestore(&cpu_buffer->reader_lock, flags);
>  }
>  
>  /**
> -- 
> 2.47.2
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>