linux-kernel - Re: [PATCH 2/2] x86/sev: let sev_es_efi_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4qola3kscsxwpxmfowsigotjwx5f4meramwjww5ut4nzq3pu6o@n4b2fco644ap>
Date: Wed, 28 May 2025 09:16:47 +0200
From: Gerd Hoffmann <kraxel@...hat.com>
To: Dionna Amalie Glaze <dionnaglaze@...gle.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, 
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	"H. Peter Anvin" <hpa@...or.com>, Ard Biesheuvel <ardb@...nel.org>, kvm@...r.kernel.org, 
	linux-coco@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH 2/2] x86/sev: let sev_es_efi_map_ghcbs map the caa pages
 too

On Tue, May 27, 2025 at 09:44:34AM -0700, Dionna Amalie Glaze wrote:
> > index a4b4ebd41b8f..1136c576831f 100644
> > --- a/arch/x86/platform/efi/efi_64.c
> > +++ b/arch/x86/platform/efi/efi_64.c
> > @@ -215,7 +215,7 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
> >          * When SEV-ES is active, the GHCB as set by the kernel will be used
> >          * by firmware. Create a 1:1 unencrypted mapping for each GHCB.
> >          */
> > -       if (sev_es_efi_map_ghcbs(pgd)) {
> > +       if (sev_es_efi_map_ghcbs_caas(pgd)) {
> >                 pr_err("Failed to create 1:1 mapping for the GHCBs!\n");
> 
> nit: update error to reflect the expanded scope?

Yep, missed that, will fix for v2.

take care,
  Gerd