linux-kernel - Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANAwSgQFbhG-VPwSsEZcMZq3VE8n14trr4uXp8MoMW3ML+vHDA@mail.gmail.com>
Date: Wed, 28 May 2025 13:03:17 +0530
From: Anand Moon <linux.amoon@...il.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Wayne Schroeder <raz@...wies.net>, 
	Kevin Hilman <khilman@...libre.com>, linux-amlogic@...ts.infradead.org, 
	Jerome Brunet <jbrunet@...libre.com>, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, 
	Neil Armstrong <neil.armstrong@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and
 reset properties

Hi Rob,

On Sat, 24 May 2025 at 00:46, Rob Herring (Arm) <robh@...nel.org> wrote:
>
>
> On Thu, 22 May 2025 22:55:31 +0530, Anand Moon wrote:
> > Add missing reset-gpios property to the USB 2.0 hub node to
> > ensure proper reset handling. Also update the vdd-supply for
> > both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> > for consistent power management.
> >
> > Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> > Signed-off-by: Anand Moon <linux.amoon@...il.com>
> > ---
> > v3: dropped remove of usb2_phy1.
> > v2: remove usb2_phy1 phy-supply since now it's managed by
> > the hub reset control.
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>   pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
>  Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250522172535.302064-1-linux.amoon@...il.com:
>
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@...09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
>         from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@...09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
>         from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
>
Ok I am able to reproduce this, it seem the issue is with second patch

Currently, I am in the process of debugging the onboard_usb_dev.c driver.
It appears that the driver is not correctly parsing the perr-hub node and
is exiting prematurely. I’ve been able to partially identify the root cause,
but I haven’t yet found a proper solution.

alarm@...oid-n2plus:~$ lsmod | grep onboard
onboard_usb_dev        20480  0
alarm@...oid-n2plus:~$

Thanks
-Anand