linux-kernel - Re: [PATCH] dt-bindings: timer: xlnx,xps-timer: Make PWM in example usable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a14be34c-de2a-4bea-9282-1fac7780b9a4@kernel.org>
Date: Wed, 28 May 2025 09:43:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sean Anderson <sean.anderson@...o.com>
Cc: linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: xlnx,xps-timer: Make PWM in example
 usable

On 27/05/2025 19:15, Uwe Kleine-König wrote:
> With #pwm-cells = <0> no usable reference to that PWM can be created.
> Even though a xlnx,xps-timer device only provides a single PWM line, Linux
> would fail to determine the right (pwmchip, pwmnumber) combination.
> 
> Fix the example to use the recommended value 3 for #pwm-cells.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
>  Documentation/devicetree/bindings/timer/xlnx,xps-timer.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
And what about the binding itself? It allows any arbitrary value.
Setting it to const=3 would not break the ABI, as long as driver does
not care.

Best regards,
Krzysztof