linux-kernel - Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c7e9077-c213-40a9-92f4-07e813a3d151@kernel.org>
Date: Wed, 28 May 2025 10:02:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charan Pedumuru <charan.pedumuru@...il.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based
 binding to json schema

On 23/05/2025 15:34, Charan Pedumuru wrote:
> Convert TI Highspeed MMC host controller binding to YAML format. Add
> 'clocks' property to resolve errors identified by 'dtb_check'.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@...il.com>
> ---
>  .../devicetree/bindings/mmc/davinci_mmc.txt        | 32 -----------
>  .../devicetree/bindings/mmc/ti,da830-mmc.yaml      | 62 ++++++++++++++++++++++
>  2 files changed, 62 insertions(+), 32 deletions(-)
> 


A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

"convert to DT Schema"



...

> +
> +allOf:
> +  - $ref: mmc-controller.yaml
> +
> +maintainers:
> +  - Rob Herring <robh@...nel.org>

No, I really doubt Rob cares about this hardware.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,da830-mmc
> +      - ti,dm355-mmc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 2
> +

This wasn't in original binding. You need to document this in the commit
msg. Also, list the items.

> +  dmas:
> +    maxItems: 2
> +
> +  dma-names:
> +    items:
> +      - const: rx
> +      - const: tx
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

why interrupts are required?


Best regards,
Krzysztof