linux-kernel - Re: [PATCH net-next 2/2] net/mlx5e: Log error messages when extack is not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250527174955.594f3617@kernel.org>
Date: Tue, 27 May 2025 17:49:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, Saeed Mahameed <saeedm@...dia.com>, Leon
 Romanovsky <leon@...nel.org>, <netdev@...r.kernel.org>,
 <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Moshe Shemesh
 <moshe@...dia.com>, Mark Bloch <mbloch@...dia.com>, Gal Pressman
 <gal@...dia.com>, Yael Chemla <ychemla@...dia.com>
Subject: Re: [PATCH net-next 2/2] net/mlx5e: Log error messages when extack
 is not present

On Sun, 25 May 2025 14:47:32 +0300 Tariq Toukan wrote:
> Encapsulate netlink error message macros to ensure error message remain
> visible in dmesg when the userspace does not support netlink.
> 
> This allows drivers to continue providing meaningful error messages even
> when netlink is available in kernel but not in userspace.
> 
> Replace direct extack macro calls with new wrapper macros to support
> this fallback behavior.

Please break this down API by API and explain for each why user space
can't use netlink. If we thought this was a good idea we would have
added the pr_err() to the NL_SET_ERR_MSG_MOD() from the start.
-- 
pw-bot: cr