linux-kernel - Re: [PATCH v10 0/5] Add Loongson Security Engine chip driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H557CLtoF23nbRQaoDPdzuM5xgsS-+-1p_VeX0OreG2vQ@mail.gmail.com>
Date: Wed, 28 May 2025 16:17:09 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Qunqin Zhao <zhaoqunqin@...ngson.cn>
Cc: lee@...nel.org, herbert@...dor.apana.org.au, jarkko@...nel.org, 
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev, davem@...emloft.net, 
	linux-crypto@...r.kernel.org, peterhuewe@....de, jgg@...pe.ca, 
	linux-integrity@...r.kernel.org
Subject: Re: [PATCH v10 0/5] Add Loongson Security Engine chip driver

On Wed, May 28, 2025 at 4:06 PM Qunqin Zhao <zhaoqunqin@...ngson.cn> wrote:
>
>
> 在 2025/5/28 下午3:17, Huacai Chen 写道:
> > Hi, Qunqin,
> >
> > As I said before, why the patch "MAINTAINERS: Add entry for Loongson
> > Security Module driver" is missing?
>
> Hi, Huacai
>
> https://lore.kernel.org/all/8e55801a-a46e-58d5-cf84-2ee8a733df9a@loongson.cn/
Sorry, I missed this email. But if you put all files in one entry, you
can merge Patch-3 and Patch-5 as the last patch (then you will also
not meet the 5 patches limit).

Huacai

>
> Thanks,
>
> Qunqin.
>
> >
> > Huacai
> >
> > On Wed, May 28, 2025 at 2:59 PM Qunqin Zhao <zhaoqunqin@...ngson.cn> wrote:
> >> The Loongson Security Engine chip supports RNG, SM2, SM3 and SM4
> >> accelerator engines. Each engine have its own DMA buffer provided
> >> by the controller. The kernel cannot directly send commands to the
> >> engine and must first send them to the controller, which will
> >> forward them to the corresponding engine. Based on these engines,
> >> TPM2 have been implemented in the chip, then let's treat TPM2 itself
> >> as an engine.
> >>
> >> v10: mfd: Cleanned up coding style.
> >>       crypto: Unlimited tfm
> >>       tpm: Added error check
> >>
> >> v9: Moved the base driver back to drivers/mfd. Cleanned up coding style.
> >>
> >> v8: Like Lee said, the base driver goes beyond MFD scope. Since these
> >>      are all encryption related drivers and SM2, SM3, and SM4 drivers
> >>      will be added to the crypto subsystem in the future, the base driver
> >>      need to be changed when adding these drivers. Therefore, it may be
> >>      more appropriate to place the base driver within the crypto
> >>      subsystem.
> >>
> >>      Removed complete callback in all driver. Removed the concepts of
> >>      "channel", "msg" and "request" as they may be confusing. Used
> >>
> >> v7: Addressed Huacai's comments.
> >>
> >> v6: mfd :MFD_LS6000SE -> MFD_LOONGSON_SE,  ls6000se.c -> loongson-se.c
> >>
> >>      crypto :CRYPTO_DEV_LS6000SE_RNG -> CRYPTO_DEV_LOONGSON_RNG,
> >>      ls6000se-rng.c ->loongson-rng.c
> >>
> >>      tpm: TCG_LSSE -> TCG_LOONGSON, tpm_lsse.c ->tpm_loongson.c
> >>
> >> v5: Registered "ls6000se-rng" device in mfd driver
> >>
> >>
> >> Qunqin Zhao (5):
> >>    mfd: Add support for Loongson Security Engine chip controller
> >>    crypto: loongson - add Loongson RNG driver support
> >>    MAINTAINERS: Add entry for Loongson crypto driver
> >>    tpm: Add a driver for Loongson TPM device
> >>    MAINTAINERS: Add tpm_loongson.c to LOONGSON CRYPTO DRIVER entry
> >>
> >>   MAINTAINERS                            |   9 +
> >>   drivers/char/tpm/Kconfig               |   9 +
> >>   drivers/char/tpm/Makefile              |   1 +
> >>   drivers/char/tpm/tpm_loongson.c        |  84 ++++++++
> >>   drivers/crypto/Kconfig                 |   1 +
> >>   drivers/crypto/Makefile                |   1 +
> >>   drivers/crypto/loongson/Kconfig        |   5 +
> >>   drivers/crypto/loongson/Makefile       |   1 +
> >>   drivers/crypto/loongson/loongson-rng.c | 211 +++++++++++++++++++++
> >>   drivers/mfd/Kconfig                    |  11 ++
> >>   drivers/mfd/Makefile                   |   2 +
> >>   drivers/mfd/loongson-se.c              | 253 +++++++++++++++++++++++++
> >>   include/linux/mfd/loongson-se.h        |  53 ++++++
> >>   13 files changed, 641 insertions(+)
> >>   create mode 100644 drivers/char/tpm/tpm_loongson.c
> >>   create mode 100644 drivers/crypto/loongson/Kconfig
> >>   create mode 100644 drivers/crypto/loongson/Makefile
> >>   create mode 100644 drivers/crypto/loongson/loongson-rng.c
> >>   create mode 100644 drivers/mfd/loongson-se.c
> >>   create mode 100644 include/linux/mfd/loongson-se.h
> >>
> >>
> >> base-commit: c89756bcf406af313d191cfe3709e7c175c5b0cd
> >> --
> >> 2.45.2
> >>
> >>
>