linux-kernel - Re: [PATCH] ring-buffer: Do not trigger WARN_ON() due to a commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250528095520.b4f236a354d9f15d65e7c2fe@kernel.org>
Date: Wed, 28 May 2025 09:55:20 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Vincent Donnefort <vdonnefort@...gle.com>
Subject: Re: [PATCH] ring-buffer: Do not trigger WARN_ON() due to a
 commit_overrun

On Tue, 27 May 2025 16:11:30 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 27 May 2025 12:11:40 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > But there just happens to be one scenario where this can legitimately
> > happen. That is on a commit_overrun. A commit overrun is when an interrupt
> > preempts an event being written to the buffer and then the interrupt adds
> > so many new events that it fills and wraps the buffer back to the commit.
> > Any new events would then be dropped and be reported as "missed_events".
> 
> I'll probably update the commit log, but the way I triggered this was to run:
> 
>  # perf record -o perf-test.dat -a -- trace-cmd record --nosplice  -e all -p function hackbench 50

Hmm, so this runs 3 commands, hackbench, which is traced by trace-cmd, which
is traced by perf.

> 
> Which causes perf to trigger a bunch of interrupts while trace-cmd enables
> function tracing and all events. This is on a debug kernel that has
> lockdep, KASAN and interrupt and preemption disabling events enabled.

Ah, that is the full-set of the interrupt and tracing :)

Thanks,

> 
> Basically, this causes a lot to be traced in an interrupt. Enough to fill
> 1.4 megs of the tracing buffer with events in interrupts before a single
> event could be recorded.
> 
> I've never triggered this when those extreme conditions were not there.
> 
> -- Steve


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>