linux-kernel - Re: [PATCH v2 1/1] local_lock: Minor improvements of local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7faca175-64c2-4a12-9340-37eaeeb8bd3e@suse.cz>
Date: Wed, 28 May 2025 11:04:43 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Leonardo Bras <leobras@...hat.com>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>,
 Thomas Gleixner <tglx@...utronix.de>, Jakub Kicinski <kuba@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] local_lock: Minor improvements of local_trylock*()
 documentation

On 5/21/25 19:47, Leonardo Bras wrote:
> Fix local_trylock_init() documentation, as it was mentioning the non-try
> helper instead, and use the opportunity to make clear the try_lock*() needs
> to receive a local_trylock_t variable as parameter.
> 
> Signed-off-by: Leonardo Bras <leobras@...hat.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

Locking tree (btw the local_lock files are missing in the list of
MAINTAINERS) or mm since this fixes up changes that went through mm recently?

> ---
> v1: https://lore.kernel.org/all/20250505170244.253170-1-leobras@redhat.com/
> RFC: https://lore.kernel.org/all/20250430073610.163846-1-leobras@redhat.com/
> 
> 
>  include/linux/local_lock.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/local_lock.h b/include/linux/local_lock.h
> index 16a2ee4f8310b..d8d5e6cfa1151 100644
> --- a/include/linux/local_lock.h
> +++ b/include/linux/local_lock.h
> @@ -45,38 +45,38 @@
>  /**
>   * local_unlock_irqrestore - Release a per CPU local lock and restore
>   *			      interrupt flags
>   * @lock:	The lock variable
>   * @flags:      Interrupt flags to restore
>   */
>  #define local_unlock_irqrestore(lock, flags)			\
>  	__local_unlock_irqrestore(lock, flags)
>  
>  /**
> - * local_lock_init - Runtime initialize a lock instance
> + * local_trylock_init - Runtime initialize a local_trylock_t instance
>   */
>  #define local_trylock_init(lock)	__local_trylock_init(lock)
>  
>  /**
>   * local_trylock - Try to acquire a per CPU local lock
> - * @lock:	The lock variable
> + * @lock:	The local_trylock_t variable
>   *
>   * The function can be used in any context such as NMI or HARDIRQ. Due to
>   * locking constrains it will _always_ fail to acquire the lock in NMI or
>   * HARDIRQ context on PREEMPT_RT.
>   */
>  #define local_trylock(lock)		__local_trylock(lock)
>  
>  /**
>   * local_trylock_irqsave - Try to acquire a per CPU local lock, save and disable
>   *			   interrupts if acquired
> - * @lock:	The lock variable
> + * @lock:	The local_trylock_t variable
>   * @flags:	Storage for interrupt flags
>   *
>   * The function can be used in any context such as NMI or HARDIRQ. Due to
>   * locking constrains it will _always_ fail to acquire the lock in NMI or
>   * HARDIRQ context on PREEMPT_RT.
>   */
>  #define local_trylock_irqsave(lock, flags)			\
>  	__local_trylock_irqsave(lock, flags)
>  
>  DEFINE_GUARD(local_lock, local_lock_t __percpu*,