linux-kernel - Re: [PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <876f65d0-e873-4c08-b404-db89e542e7a3@redhat.com>
Date: Wed, 28 May 2025 11:06:10 +0200
From: David Hildenbrand <david@...hat.com>
To: Tal Zussman <tz2294@...umbia.edu>, Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Ingo Molnar <mingo@...nel.org>, Rik van Riel <riel@...riel.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Vlastimil Babka
 <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 x86@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-mm@...ck.org
Subject: Re: [PATCH 1/2] x86/tlb/trace: Export the TLB_REMOTE_WRONG_CPU enum

On 28.05.25 07:35, Tal Zussman wrote:
> When the TLB_REMOTE_WRONG_CPU enum was introduced for the tlb_flush
> tracepoint, the enum was not exported to userspace. Add it to the
> appropriate macro definition to enable parsing by userspace tools, as
> per [0].
> 
> [0] Link: https://lore.kernel.org/all/20150403013802.220157513@goodmis.org
> 
> Fixes: 2815a56e4b72 ("x86/mm/tlb: Add tracepoint for TLB flush IPI to stale CPU")
> Signed-off-by: Tal Zussman <tz2294@...umbia.edu>
> ---
>   include/trace/events/tlb.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/tlb.h b/include/trace/events/tlb.h
> index b4d8e7dc38f8..725a75720a23 100644
> --- a/include/trace/events/tlb.h
> +++ b/include/trace/events/tlb.h
> @@ -13,7 +13,8 @@
>   	EM(  TLB_REMOTE_SHOOTDOWN,	"remote shootdown" )		\
>   	EM(  TLB_LOCAL_SHOOTDOWN,	"local shootdown" )		\
>   	EM(  TLB_LOCAL_MM_SHOOTDOWN,	"local mm shootdown" )		\
> -	EMe( TLB_REMOTE_SEND_IPI,	"remote ipi send" )
> +	EM(  TLB_REMOTE_SEND_IPI,	"remote ipi send" )		\
> +	EMe( TLB_REMOTE_WRONG_CPU,	"remote wrong CPU" )

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb