linux-kernel - Re: [PATCH v7 2/3] arm64: dts: qcom: qcs615: add venus node to devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a9e7daf-c0df-42db-b02d-96d9893afcde@quicinc.com>
Date: Wed, 28 May 2025 17:13:06 +0800
From: Renjiang Han <quic_renjiang@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Dikshita Agarwal <quic_dikshita@...cinc.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 2/3] arm64: dts: qcom: qcs615: add venus node to
 devicetree


On 5/27/2025 9:57 PM, Konrad Dybcio wrote:
> On 5/27/25 5:32 AM, Renjiang Han wrote:
>> Add the venus node to the devicetree for the qcs615 platform to enable
>> video functionality. The qcs615 platform currently lacks video
>> functionality due to the absence of the venus node. Fallback to sc7180 due
>> to the same video core.
>>
>> Signed-off-by: Renjiang Han <quic_renjiang@...cinc.com>
>> ---
> [...]
>
>> +			interconnects = <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS
>> +					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>> +					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
>> +					 &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ALWAYS>;
> QCOM_ICC_TAG_ACTIVE_ONLY on the second path

Thanks for your comment. I'll update it in next version.

             interconnects = <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS
                      &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
                     <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
                      &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>;

>> +			interconnect-names = "video-mem",
>> +					     "cpu-cfg";
>> +
>> +			iommus = <&apps_smmu 0xe40 0x20>;
> fwiw docs mention 0xe60 0x20 (which result in the exact same resulting sid)
OK. Will update it with next version.
>> +
>> +			memory-region = <&pil_video_mem>;
>> +
>> +			status = "disabled";
>> +
>> +			venus_opp_table: opp-table {
>> +				compatible = "operating-points-v2";
>> +
>> +				opp-133330000 {
>> +					opp-hz = /bits/ 64 <133330000>;
>> +					required-opps = <&rpmhpd_opp_low_svs>;
>> +				};
>> +
>> +				opp-240000000 {
>> +					opp-hz = /bits/ 64 <240000000>;
>> +					required-opps = <&rpmhpd_opp_svs>;
>> +				};
>> +
>> +				opp-300000000 {
>> +					opp-hz = /bits/ 64 <300000000>;
>> +					required-opps = <&rpmhpd_opp_svs_l1>;
>> +				};
>> +
>> +				opp-380000000 {
>> +					opp-hz = /bits/ 64 <380000000>;
>> +					required-opps = <&rpmhpd_opp_nom>;
>> +				};
>> +
>> +				opp-410000000 {
>> +					opp-hz = /bits/ 64 <410000000>;
>> +					required-opps = <&rpmhpd_opp_turbo>;
> nom_l1
>
>> +				};
>> +
>> +				opp-460000000 {
>> +					opp-hz = /bits/ 64 <460000000>;
>> +					required-opps = <&rpmhpd_opp_turbo_l1>;
> turbo

Thanks for your comment, will update like this in next version.

                 opp-410000000 {

                     opp-hz = /bits/ 64 <410000000>;
                     required-opps = <&rpmhpd_opp_nom_l1>;
                 };

                 opp-460000000 {
                     opp-hz = /bits/ 64 <460000000>;
                     required-opps = <&rpmhpd_opp_turbo>;
                 };
>
> Konrad

-- 
Best Regards,
Renjiang