linux-kernel - Re: [PATCH] devres: Move remaining devm_alloc_percpu and devm_device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDbX6natYH6Pu2ED@smile.fi.intel.com>
Date: Wed, 28 May 2025 12:31:22 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Pei Xiao <xiaopei01@...inos.cn>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	rafael@...nel.org, dakr@...nel.org, bartosz.golaszewski@...aro.org
Subject: Re: [PATCH] devres: Move remaining devm_alloc_percpu and
 devm_device_add_group to devres.h

On Wed, May 28, 2025 at 11:07:43AM +0800, Pei Xiao wrote:
> 
> 在 2025/5/27 19:09, Andy Shevchenko 写道:
> > On Tue, May 27, 2025 at 05:41:21PM +0800, Pei Xiao wrote:
> >> 在 2025/5/22 20:54, Andy Shevchenko 写道:
> >>> On Thu, May 22, 2025 at 05:01:26PM +0800, Pei Xiao wrote:

...

> >> include #include <asm/percpu.h>
> >>
> >> only move #include <asm/percpu.h> to linux/device/devres.h for
> >>
> >> build error.
> > It's not needed for the build error fixing as far as I understood it. __percpu
> > is defined in another header.
> 
> compiler_types.h or compiler.h 
> 
> I tried before send patch, but it all resulted in compilation failures on my arm64 machine.

You need to investigate those. But header doesn't use anything fancy AFAICS, so
compiler_types.h should be enough. I think you need to move asm/percpu.h to
devres.c (C file).

...

> >>>> +#include <linux/sysfs.h>
> >> it's redundant.
> >>>> +#include <asm/percpu.h>
> >>> What for are these new inclusions, please?
> >> for percpu.
> > It does not define __percpu.
> >
> >>>> +void devm_free_percpu(struct device *dev, void __percpu *pdata);
> >>> Please, take your time to understand what is behind the __percpu and
> >>> why the asm/percpu.h is redundant here.
> >> If this header file is missing, there will be a compilation error. 
> > Right. But this is wrong header for the purpose.
> >
> >> Which header file should I include?
> > The one that defines it, hint:
> > https://elixir.bootlin.com/linux/v6.15/A/ident/__percpu
> 
> compiler_types.h or compiler.h 
> 
> I tried before send patch, but it all resulted in compilation failures on my arm64 machine.
> 
>  You can give it a try.

Sure.

> when i add a error in compiler_types.h
> 
> +++ b/include/linux/compiler_types.h
> @@ -26,6 +26,7 @@
>  
>  /* sparse defines __CHECKER__; see Documentation/dev-tools/sparse.rst */
>  #ifdef __CHECKER__
> +sasasas
>  /* address spaces */
>  # define __kernel      __attribute__((address_space(0)))
>  # define __user                __attribute__((noderef, address_space(__user)
> 
> it  still build success,have no build error.
> 
> #include <linux/lockdep.h> include <asm/percpu.h> ,so have no build error before modidy,I think.
> 
> >> I've found that including <asm/percpu.h> does resolve my compilation issue.
> thanks!

-- 
With Best Regards,
Andy Shevchenko