linux-kernel - RE: [PATCH] i2c: imx: fix emulated smbus block read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <VI2PR04MB11147341238F4D0531E1E6102E867A@VI2PR04MB11147.eurprd04.prod.outlook.com>
Date: Wed, 28 May 2025 01:50:51 +0000
From: Carlos Song <carlos.song@....com>
To: KUCHARCZYK Lukasz <lukasz.kucharczyk@...ca-geosystems.com>, Oleksij Rempel
	<o.rempel@...gutronix.de>, "stefan.eichenberger@...adex.com"
	<stefan.eichenberger@...adex.com>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Andi Shyti <andi.shyti@...nel.org>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>
CC: "open list:FREESCALE IMX I2C DRIVER" <linux-i2c@...r.kernel.org>, "open
 list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@...ts.infradead.org>, open list
	<linux-kernel@...r.kernel.org>, GEO-CHHER-bsp-development
	<bsp-development.geo@...ca-geosystems.com>,
	"customers.leicageo@...gutronix.de" <customers.leicageo@...gutronix.de>
Subject: RE: [PATCH] i2c: imx: fix emulated smbus block read



> -----Original Message-----
> From: KUCHARCZYK Lukasz <lukasz.kucharczyk@...ca-geosystems.com>
> Sent: Tuesday, May 27, 2025 8:03 PM
> To: Carlos Song <carlos.song@....com>; Oleksij Rempel
> <o.rempel@...gutronix.de>; stefan.eichenberger@...adex.com; Pengutronix
> Kernel Team <kernel@...gutronix.de>; Andi Shyti <andi.shyti@...nel.org>;
> Shawn Guo <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>;
> Fabio Estevam <festevam@...il.com>
> Cc: open list:FREESCALE IMX I2C DRIVER <linux-i2c@...r.kernel.org>; open
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <imx@...ts.linux.dev>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@...ts.infradead.org>; open list
> <linux-kernel@...r.kernel.org>; GEO-CHHER-bsp-development
> <bsp-development.geo@...ca-geosystems.com>;
> customers.leicageo@...gutronix.de
> Subject: [EXT] RE: [PATCH] i2c: imx: fix emulated smbus block read
> 
> [You don't often get email from lukasz.kucharczyk@...ca-geosystems.com.
> Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> > -----Original Message-----
> > From: Carlos Song <carlos.song@....com>
> > Sent: 27 May 2025 12:46
> > Subject: RE: [PATCH] i2c: imx: fix emulated smbus block read
> >
> > I2C SMBUS block read need first read one byte from data length offset
> > then I2C will know how many bytes need to continue read. For this
> > issue you can meet " Error: Read failed " when using i2cget -f -y bus address
> offset s to test.
> >
> > So you apply this change to make i2c-imx controller can behavior like this:
> >
> > S Addr Wr [A] Comm [A] Sr Addr Rd [A] [Count] A [Data] A [Data] A ...
> > A [Data] NA P
> >
> > Do I understand this right?
> 
> hi Carlos; thanks for the message! Yes, exactly, that's correct.
> 
> I run into this issue while trying to integrate a smart battery into a IMX8-based
> system. Fetching of properties that rely on data block read operation (i.e.,
> ManufacturerName, DeviceName,  DeviceChemistry and
> ManufacturerData) was failing.
> 
> With the fix the block read looks just like you described.
> 
> 
> Without the fix, the transaction on the bus looked somehow like:
> S Addr Wr [A] Comm [A] Sr Addr Rd [A] [Count] NA [0xff] NA [0xff] NA ... [0xff]
> NA P
> 
> (i.e., the Count is not acknowledged and SDA remains high afterwards).
> 

Good, thank you for your work!
Reviewed-by: Carlos Song <carlos.song@....com>

> Lukasz