linux-kernel - Re: [PATCH v2 1/1] netfilter: load nf_log_syslog on enabling nf_conntrack_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2f5fb23-e57a-4a83-bb95-b5756df0e2d7@linux.dev>
Date: Wed, 28 May 2025 19:42:50 +0800
From: Lance Yang <lance.yang@...ux.dev>
To: Florian Westphal <fw@...len.de>
Cc: pablo@...filter.org, coreteam@...filter.org, davem@...emloft.net,
 Lance Yang <ioworker0@...il.com>, edumazet@...gle.com, horms@...nel.org,
 kadlec@...filter.org, kuba@...nel.org, linux-kernel@...r.kernel.org,
 netfilter-devel@...r.kernel.org, pabeni@...hat.com, zi.li@...ux.dev
Subject: Re: [PATCH v2 1/1] netfilter: load nf_log_syslog on enabling
 nf_conntrack_log_invalid


Thanks for taking the time to review!

On 2025/5/28 19:05, Florian Westphal wrote:
> Lance Yang <ioworker0@...il.com> wrote:
>> From: Lance Yang <lance.yang@...ux.dev>
>>
>> When no logger is registered, nf_conntrack_log_invalid fails to log invalid
>> packets, leaving users unaware of actual invalid traffic. Improve this by
>> loading nf_log_syslog, similar to how 'iptables -I FORWARD 1 -m conntrack
>> --ctstate INVALID -j LOG' triggers it.
> 
> Acked-by: Florian Westphal <fw@...len.de>

Hmm... should this patch be backported to stable kernels? Without it,
nf_conntrack_log_invalid won't log invalid packets when no logger is
registered, causing unnecessary debugging effort ;)

Back then, I actually thought my machine wasn't seeing any invalid
packets... turns out they just weren't logged in dmesg :(

Thanks,
Lance