linux-kernel - Re: [PATCH 01/17] pinctrl: starfive: Allow compile testing on other platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdX7krbAssbYpJ1RA1EkpOP26nUhuhmtSW8X9nJkB5amBQ@mail.gmail.com>
Date: Wed, 28 May 2025 14:36:20 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, Basavaraj Natikar <Basavaraj.Natikar@....com>, 
	Shyam Sundar S K <Shyam-sundar.S-k@....com>, Andrew Jeffery <andrew@...econstruct.com.au>, 
	Joel Stanley <joel@....id.au>, Avi Fishman <avifishman70@...il.com>, 
	Tomer Maimon <tmaimon77@...il.com>, Tali Perry <tali.perry1@...il.com>, 
	Patrick Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>, 
	Benjamin Fair <benjaminfair@...gle.com>, Jonathan Neuschäfer <j.neuschaefer@....net>, 
	Rafał Miłecki <rafal@...ecki.pl>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	David Rhodes <david.rhodes@...rus.com>, Richard Fitzgerald <rf@...nsource.cirrus.com>, 
	Charles Keepax <ckeepax@...nsource.cirrus.com>, Lorenzo Bianconi <lorenzo@...nel.org>, 
	Sean Wang <sean.wang@...nel.org>, Jesper Nilsson <jesper.nilsson@...s.com>, 
	Lars Persson <lars.persson@...s.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Damien Le Moal <dlemoal@...nel.org>, 
	Vladimir Zapolskiy <vz@...ia.com>, Michal Simek <michal.simek@....com>, 
	Emil Renner Berthing <kernel@...il.dk>, Jianlong Huang <jianlong.huang@...rfivetech.com>, 
	Hal Feng <hal.feng@...rfivetech.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org, 
	openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org, 
	linux-renesas-soc@...r.kernel.org, linux-sound@...r.kernel.org, 
	patches@...nsource.cirrus.com, linux-mediatek@...ts.infradead.org, 
	linux-arm-kernel@...s.com, linux-riscv@...ts.infradead.org, 
	linux-rtc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 01/17] pinctrl: starfive: Allow compile testing on other platforms

Hi Krzysztof,

On Wed, 28 May 2025 at 12:41, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> Always descent to drivers/pinctrl/starfive/ because limiting it with
> SOC_STARFIVE is redundant since all of its Kconfig entries are already

... since its Makefile doesn't build anything if no Starfive-specific
pin control Kconfig options are enabled?

> have "depends on SOC_STARFIVE".  This allows compile testing on other
> architectures with allyesconfig.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/pinctrl/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index ac27e88677d14f1c697e0d0be9f295c746556f4d..dcede70b25660833a158c298d1269d6ecea9dd8b 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -82,7 +82,7 @@ obj-y                         += sophgo/
>  obj-y                          += spacemit/
>  obj-$(CONFIG_PINCTRL_SPEAR)    += spear/
>  obj-y                          += sprd/
> -obj-$(CONFIG_SOC_STARFIVE)     += starfive/
> +obj-y                          += starfive/
>  obj-$(CONFIG_PINCTRL_STM32)    += stm32/
>  obj-y                          += sunplus/
>  obj-$(CONFIG_PINCTRL_SUNXI)    += sunxi/

The actual change LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds