linux-kernel - Re: [PATCH] Documentation: cgroup: clarify controller enabling semantics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDcNLTA2JfoLXdIM@linux.ibm.com>
Date: Wed, 28 May 2025 18:48:37 +0530
From: Vishal Chourasia <vishalc@...ux.ibm.com>
To: Michal Koutný <mkoutny@...e.com>
Cc: Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>,
        Jonathan Corbet <corbet@....net>, cgroups@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: cgroup: clarify controller enabling
 semantics

On Tue, May 27, 2025 at 11:58:50AM +0200, Michal Koutný wrote:
> Hello.
> 
> On Tue, May 27, 2025 at 02:23:36PM +0530, Vishal Chourasia <vishalc@...ux.ibm.com> wrote:
> > --- a/Documentation/admin-guide/cgroup-v2.rst
> > +++ b/Documentation/admin-guide/cgroup-v2.rst
> > @@ -438,8 +438,8 @@ Controlling Controllers
> >  Enabling and Disabling
> >  ~~~~~~~~~~~~~~~~~~~~~~
> >  
> > -Each cgroup has a "cgroup.controllers" file which lists all
> > -controllers available for the cgroup to enable::
> > +Each cgroup has a cgroup.controllers file, which lists all the controllers
> > +available for that cgroup and which can be enabled for its children.
> >  
> >    # cat cgroup.controllers
> >    cpu io memory
> 
> Honestly, I see little difference between the two resulting formulations.
> Could you perhaps add an example where the documentation confused you or
> behavior was not what you expected based on the docs?
Hello Michal,

The part that was confused me, was the meaning behind controller being
available vs. enabled in a cgroup.

Though, the documentation does mention what it means for a controller to
be enabled in a cgroup later in the text. But at the point of the
change it is unclear.

Thanks
Vishal


> 
> Thanks,
> Michal