linux-kernel - Re: [PATCH] drm/bridge: analogix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jeslyq3zv3l3fakeixfpxw2xeoq55jraag7pfn6xbq65h3armq@uq76bx7xyydo>
Date: Wed, 28 May 2025 08:56:51 -0500
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Heiko Stuebner <heiko@...ech.de>, Dmitry Baryshkov
	<dmitry.baryshkov@....qualcomm.com>
CC: <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>,
	<rfoss@...nel.org>, <Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
	<jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/bridge: analogix_dp: Fix clk-disable removal

On Wed, May 28, 2025 at 12:51:19AM +0200, Heiko Stuebner wrote:
>Commit 6579a03e68ff ("drm/bridge: analogix_dp: Remove the unnecessary
>calls to clk_disable_unprepare() during probing") removed the mismatched
>clock_disable calls from analogix_dp_probe.
>
>But that patch was created and sent before
>commit e5e9fa9f7aad ("drm/bridge: analogix_dp: Add support to get panel
>from the DP AUX bus") was merged, so couldn't know about this change.
>
>So in the original patch the last change is
>    if (ret) {
>	dev_err(&pdev->dev, "failed to request irq\n");
>-		goto err_disable_clk;
>+		return ERR_PTR(ret);
>    }
>    disable_irq(dp->irq);
>
>    return dp;
>-
>-err_disable_clk:
>-	clk_disable_unprepare(dp->clock);
>-	return ERR_PTR(ret);
> }
> EXPORT_SYMBOL_GPL(analogix_dp_probe);
>
>the analogix_dp_core.c actually now has the runtime-pm handling between
>disable_irq() and return do introducing another goto err_clk_disable there.
>
>So remove that one too and return an error pointer, to not create build
>breakage.
>
>Fixes: 6579a03e68ff ("drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing")
>Signed-off-by: Heiko Stuebner <heiko@...ech.de>

Reviewed-by: Lucas De Marchi <lucas.demarchi@...el.com>

Dmitry, maybe you have to enable a config in your build tests so we
don't have broken builds?

Lucas De Marchi