linux-kernel - Re: [PATCH v13 18/27] x86/resctrl: Add definitions for MBM event configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8216838-aa71-490f-809b-127bad909f1e@intel.com>
Date: Thu, 29 May 2025 13:58:33 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: <babu.moger@....com>, <corbet@....net>, <tony.luck@...el.com>,
	<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
	<dave.hansen@...ux.intel.com>
CC: <james.morse@....com>, <dave.martin@....com>, <fenghuay@...dia.com>,
	<x86@...nel.org>, <hpa@...or.com>, <paulmck@...nel.org>,
	<akpm@...ux-foundation.org>, <thuth@...hat.com>, <rostedt@...dmis.org>,
	<ardb@...nel.org>, <gregkh@...uxfoundation.org>,
	<daniel.sneddon@...ux.intel.com>, <jpoimboe@...nel.org>,
	<alexandre.chartre@...cle.com>, <pawan.kumar.gupta@...ux.intel.com>,
	<thomas.lendacky@....com>, <perry.yuan@....com>, <seanjc@...gle.com>,
	<kai.huang@...el.com>, <xiaoyao.li@...el.com>, <kan.liang@...ux.intel.com>,
	<xin3.li@...el.com>, <ebiggers@...gle.com>, <xin@...or.com>,
	<sohil.mehta@...el.com>, <andrew.cooper3@...rix.com>,
	<mario.limonciello@....com>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <peternewman@...gle.com>,
	<maciej.wieczor-retman@...el.com>, <eranian@...gle.com>,
	<Xiaojian.Du@....com>, <gautham.shenoy@....com>
Subject: Re: [PATCH v13 18/27] x86/resctrl: Add definitions for MBM event
 configuration

Hi Babu,

On 5/29/25 12:00 PM, Moger, Babu wrote:
> On 5/22/25 23:41, Reinette Chatre wrote:
>> On 5/15/25 3:52 PM, Babu Moger wrote:


>>> +/**
>>> + * struct mbm_evt_value - Specific type of memory events.
>>
>> I am trying to decipher the terminology. If these are events, then it becomes confusing
>> since it becomes "these events are used to configure events". You mention "memory
>> transaction" below, this sounds more accurate to me. Above could thus be:
>>
>> struct mbm_evt_value - Memory transaction an MBM event can be configured with.
> 
> Sure.
> 
>>
>> The name of the struct could also do with a rename to avoid the "event" term that
>> conflicts with the actual MBM events. Maybe "mbm_cfg_value" ... I do not think this
>> is a good name so please consider what would work better.
> 
> I can change it to "mbm_config_value".

Looks good, thank you.

...

>>> +#define NUM_MBM_EVT_VALUES             7
>>> +
>>> +/* Decoded values for each type of memory events */
>>
>> Please be consistent with terminology. In the above lines it switches
>> between "memory transaction types" and "memory events".
> 
> "Decoded values for each type of memory transaction types"

I do not think "type" is needed twice. Could also be:
"Decoded values of each memory transaction type."

> 
>>
>>> +struct mbm_evt_value mbm_evt_values[NUM_MBM_EVT_VALUES] = {
>>> +	{"local_reads", READS_TO_LOCAL_MEM},
>>> +	{"remote_reads", READS_TO_REMOTE_MEM},
>>> +	{"local_non_temporal_writes", NON_TEMP_WRITE_TO_LOCAL_MEM},
>>> +	{"remote_non_temporal_writes", NON_TEMP_WRITE_TO_REMOTE_MEM},
>>> +	{"local_reads_slow_memory", READS_TO_LOCAL_S_MEM},
>>> +	{"remote_reads_slow_memory", READS_TO_REMOTE_S_MEM},
>>> +	{"dirty_victim_writes_all", DIRTY_VICTIMS_TO_ALL_MEM},
>>> +};


Reinette