linux-kernel - Re: [PATCH v4 20/20] gpu: nova-core: load and run FWSEC-FRTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31707e2b49015e52f5b1fe185ea6791538c4034f.camel@nvidia.com>
Date: Thu, 29 May 2025 21:30:27 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dakr@...nel.org" <dakr@...nel.org>, "a.hindborg@...nel.org"
	<a.hindborg@...nel.org>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"benno.lossin@...ton.me" <benno.lossin@...ton.me>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Alexandre Courbot
	<acourbot@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>
CC: Alistair Popple <apopple@...dia.com>, John Hubbard <jhubbard@...dia.com>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Joel Fernandes
	<joelagnelf@...dia.com>, Ben Skeggs <bskeggs@...dia.com>
Subject: Re: [PATCH v4 20/20] gpu: nova-core: load and run FWSEC-FRTS

On Wed, 2025-05-21 at 15:45 +0900, Alexandre Courbot wrote:

I noticed something interesting in this change to Gpu::new().

> +        // Check that the WPR2 region does not already exists - if it does, the GPU needs to be
> +        // reset.
> +        if regs::NV_PFB_PRI_MMU_WPR2_ADDR_HI::read(bar).hi_val() != 0 {
> +            dev_err!(
> +                pdev.as_ref(),
> +                "WPR2 region already exists - GPU needs to be reset to proceed\n"
> +            );
> +            return Err(EBUSY);
> +        }

You have a lot of checks in this code that display an error message and then return an Err().

But then ...

> +
> +        // Reset falcon, load FWSEC-FRTS, and run it.
> +        gsp_falcon.reset(bar)?;
> +        gsp_falcon.dma_load(bar, &fwsec_frts)?;
> +        let (mbox0, _) = gsp_falcon.boot(bar, Some(0), None)?;
> +        if mbox0 != 0 {
> +            dev_err!(pdev.as_ref(), "FWSEC firmware returned error {}\n", mbox0);
> +            return Err(EINVAL);
> +        }

There are several lines where you just terminate them with "?".  This means that no error message is
displays. 

I think all of these ? should be replaced with something like:

	gsp_falcon.reset(bar).inspect_err(|e| {
            dev_err!(pdev.as_ref(), "Failed to reset GSP falcon: {:?}\n", e);
        })?;

This feels like something that would benefit from a macro, but I can't imagine what that would look
like.