linux-kernel - Re: [PATCH 04/15] KVM: x86: Drop superfluous kvm_hv_set_sint() => kvm_hv_synic_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9385b67be52925e52ac023e1f1d046d345514c5d.camel@intel.com>
Date: Thu, 29 May 2025 22:34:49 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "seanjc@...gle.com" <seanjc@...gle.com>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: Re: [PATCH 04/15] KVM: x86: Drop superfluous kvm_hv_set_sint() =>
 kvm_hv_synic_set_irq() wrapper

On Thu, 2025-05-29 at 07:39 -0700, Sean Christopherson wrote:
> On Thu, May 29, 2025, Kai Huang wrote:
> > On Mon, 2025-05-19 at 16:27 -0700, Sean Christopherson wrote:
> > > Drop the superfluous kvm_hv_set_sint() and instead wire up ->set() directly
> > > to its final destination.
> > 
> > kvm_hv_set_sint() is still there after this patch.  Did you mean "superfluous
> > kvm_hv_synic_set_irq()"? :-)
> 
> Ugh, yeah, bad changelog.  Maybe this?
> 
>   Rename kvm_hv_synic_set_irq() to kvm_hv_set_sint() and drop the previous
>   incarnation of kvm_hv_set_sint() provided by irq_comm.c, which is just a
>   wrapper to the hyperv.c code.
> 
> That said, given that the tracepoint is trace_kvm_hv_synic_set_irq(), and that
> the IOAPIC and PIC versions are kvm_ioapic_set_irq() and kvm_pic_set_irq()
> respectively, I'm leaning towards a straight drop of kvm_hv_set_sint(), i.e. keep
> kvm_hv_synic_set_irq().

Yeah LGTM.  Thanks.