linux-kernel - Re: [PATCH] i2c: i801: Do not instantiate spd5118 under SPD Write Disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABscksPBjQ14UrvCVwgVMHZ6NsPKN9tWscaOGBy8TjufgzPGFA@mail.gmail.com>
Date: Thu, 29 May 2025 11:54:49 +0800
From: "Yo-Jung (Leo) Lin" <leo.lin@...onical.com>
To: kernel test robot <lkp@...el.com>
Cc: Jean Delvare <jdelvare@...e.com>, Andi Shyti <andi.shyti@...nel.org>, 
	Wolfram Sang <wsa-dev@...g-engineering.com>, oe-kbuild-all@...ts.linux.dev, 
	Guenter Roeck <linux@...ck-us.net>, "Chia-Lin Kao (AceLan)" <acelan.kao@...onical.com>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i801: Do not instantiate spd5118 under SPD Write Disable

On Thu, May 29, 2025 at 8:00 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Yo-Jung,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on 176e917e010cb7dcc605f11d2bc33f304292482b]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Yo-Jung-Leo-Lin/i2c-i801-Do-not-instantiate-spd5118-under-SPD-Write-Disable/20250528-163253
> base:   176e917e010cb7dcc605f11d2bc33f304292482b
> patch link:    https://lore.kernel.org/r/20250528-for-upstream-not-instantiate-spd5118-v1-1-8216e2d38918%40canonical.com
> patch subject: [PATCH] i2c: i801: Do not instantiate spd5118 under SPD Write Disable
> config: loongarch-randconfig-001-20250529 (https://download.01.org/0day-ci/archive/20250529/202505290728.VsNgBfDO-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 15.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250529/202505290728.VsNgBfDO-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505290728.VsNgBfDO-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    drivers/i2c/busses/i2c-i801.c: In function 'i801_notifier_call':
> >> drivers/i2c/busses/i2c-i801.c:1304:9: error: implicit declaration of function '__i801_register_spd' [-Wimplicit-function-declaration]
>     1304 |         __i801_register_spd(priv);
>          |         ^~~~~~~~~~~~~~~~~~~
>
>
> vim +/__i801_register_spd +1304 drivers/i2c/busses/i2c-i801.c
>
>   1291
>   1292  static int i801_notifier_call(struct notifier_block *nb, unsigned long action,
>   1293                                void *data)
>   1294  {
>   1295          struct i801_priv *priv = container_of(nb, struct i801_priv, mux_notifier_block);
>   1296          struct device *dev = data;
>   1297
>   1298          if (action != BUS_NOTIFY_ADD_DEVICE ||
>   1299              dev->type != &i2c_adapter_type ||
>   1300              i2c_root_adapter(dev) != &priv->adapter)
>   1301                  return NOTIFY_DONE;
>   1302
>   1303          /* Call i2c_register_spd for muxed child segments */
> > 1304          __i801_register_spd(priv);
>   1305
>   1306          return NOTIFY_OK;
>   1307  }
>   1308

I think this happens likely because I put the __i801_register_spd() inside the:

#if defined CONFIG_X86 && defined CONFIG_DMI
...
#endif

So the function went missing in loongarch. Will fix this in v2.

>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki