linux-kernel - Re: [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this out of CI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025052937-certainty-encode-4085@gregkh>
Date: Thu, 29 May 2025 06:47:12 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Kees Cook <kees@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>,
	Justin Stitt <justinstitt@...gle.com>,
	Eric Biggers <ebiggers@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Jann Horn <jannh@...gle.com>, Marco Elver <elver@...gle.com>,
	llvm@...ts.linux.dev, linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this
 out of CI

On Wed, May 28, 2025 at 04:00:03PM -0700, Kees Cook wrote:
> On Wed, May 28, 2025 at 02:32:23PM -0700, Nathan Chancellor wrote:
> > On Wed, May 28, 2025 at 11:26:22AM -0700, Kees Cook wrote:
> > > Depending on !COMPILE_TEST isn't sufficient to keep this feature out of
> > > CI because we can't stop it from being included in randconfig builds.
> > > This feature is still highly experimental, and is developed in lock-step
> > > with Clang's Overflow Behavior Types[1]. Depend on BROKEN to keep it
> > > from being enabled by anyone not expecting it.
> > > 
> > > Link: https://discourse.llvm.org/t/rfc-v2-clang-introduce-overflowbehaviortypes-for-wrapping-and-non-wrapping-arithmetic/86507 [1]
> > > Signed-off-by: Kees Cook <kees@...nel.org>
> > 
> > Should this have a 'Cc: stable@...r.kernel.org' on it? There might not
> > be much randconfig testing on stable but it is still very much possible
> > for some random user to turn this on and report problems.
> 
> Ah yeah, I should probably do this via a proper Fixes: tag. I'll add
> this.

Nit, "Fixes:" tags alone without a cc: stable do not guarantee they will
end up in the stable trees.  Always explicitly add a cc: please.

thanks,

greg k-h