linux-kernel - Re: [PATCH] leds: flash: leds-qcom-flash: Fix registry access after re-bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b2f664d-8e89-460f-a8df-d3fab13fe889@linaro.org>
Date: Thu, 29 May 2025 08:31:17 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Fenglin Wu <fenglin.wu@....qualcomm.com>, Lee Jones <lee@...nel.org>,
 Pavel Machek <pavel@...nel.org>, linux-leds@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH] leds: flash: leds-qcom-flash: Fix registry access after
 re-bind

On 29/05/2025 05:11, Fenglin Wu wrote:
>> -static struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
>> +static const struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
>>   	REG_FIELD(0x06, 0, 7),			/* status1	*/
>>   	REG_FIELD(0x07, 0, 6),			/* status2	*/
>>   	REG_FIELD(0x09, 0, 7),			/* status3	*/
>> @@ -854,11 +854,17 @@ static int qcom_flash_led_probe(struct platform_device *pdev)
>>   	if (val == FLASH_SUBTYPE_3CH_PM8150_VAL || val == FLASH_SUBTYPE_3CH_PMI8998_VAL) {
>>   		flash_data->hw_type = QCOM_MVFLASH_3CH;
>>   		flash_data->max_channels = 3;
>> -		regs = mvflash_3ch_regs;
>> +		regs = devm_kmemdup(dev, mvflash_3ch_regs, sizeof(mvflash_3ch_regs),
>> +				    GFP_KERNEL);
>> +		if (!regs)
>> +			return -ENOMEM;
>>   	} else if (val == FLASH_SUBTYPE_4CH_VAL) {
>>   		flash_data->hw_type = QCOM_MVFLASH_4CH;
>>   		flash_data->max_channels = 4;
>> -		regs = mvflash_4ch_regs;
>> +		regs = devm_kmemdup(dev, mvflash_4ch_regs, sizeof(mvflash_3ch_regs),
> 
> Minor: sizeof(mvflash_4ch_regs)

Copy paste, thanks.

> 



Best regards,
Krzysztof