linux-kernel - [PATCH] wifi: mac80211: Add limit to ignore NSS change warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250529070922.3467-1-pmenzel@molgen.mpg.de>
Date: Thu, 29 May 2025 09:09:21 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Johannes Berg <johannes@...solutions.net>
Cc: Paul Menzel <pmenzel@...gen.mpg.de>,
	linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] wifi: mac80211: Add limit to ignore NSS change warning

Currently, Linux warns as below:

    Ignoring NSS change in VHT Operating Mode Notification from cc:d4:2e:bb:59:f4 with invalid nss 4

For the ignorant reader, it’s unclear, why it’s invalid. Checking the
code, valid means it’s smaller or equal to `link_sta->op_mode_nss,` so
add that to the warning.

Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
---
 net/mac80211/vht.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/vht.c b/net/mac80211/vht.c
index c5c5d16ed6c8..9f7938ac4031 100644
--- a/net/mac80211/vht.c
+++ b/net/mac80211/vht.c
@@ -672,8 +672,8 @@ u32 __ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data *sdata,
 				sta_opmode.changed |= STA_OPMODE_N_SS_CHANGED;
 			}
 		} else {
-			pr_warn_ratelimited("Ignoring NSS change in VHT Operating Mode Notification from %pM with invalid nss %d",
-					    link_sta->pub->addr, nss);
+			pr_warn_ratelimited("Ignoring NSS change in VHT Operating Mode Notification from %pM with invalid nss %d > %d",
+					    link_sta->pub->addr, nss, link_sta->op_mode_nss);
 		}
 	}
 
-- 
2.49.0