linux-kernel - Re: [PATCH] wifi: mwifiex: enable host mlme on sdio W8997 chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250529072028.GA75868@francesco-nb>
Date: Thu, 29 May 2025 09:20:28 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Brian Norris <briannorris@...omium.org>
Cc: Francesco Dolcini <francesco@...cini.it>, rafael@...ms.me,
	Rafael Beims <rafael.beims@...adex.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: enable host mlme on sdio W8997 chipsets

Hello Brian,

On Wed, May 28, 2025 at 10:05:03AM -0700, Brian Norris wrote:
> On Fri, May 23, 2025 at 09:26:04AM +0200, Francesco Dolcini wrote:
> > On Thu, May 22, 2025 at 10:24:14AM -0700, Brian Norris wrote:
> > > On Wed, May 21, 2025 at 07:19:34AM -0300, rafael@...ms.me wrote:
> > > > From: Rafael Beims <rafael.beims@...adex.com>
> > > > 
> > > > Enable the host mlme flag for W8997 chipsets so WPA3 can be used.
> > > > This feature depends on firmware support (V2 API key), which may not be
> > > > available in all available firmwares.
> > > 
> > > Is it available in *any* W8997 firmware? Or particularly, is it
> > > available in the firmware in linux-firmware.git? Judging by its git
> > > history, the answer is "no", in which case this is definitely NAK'd.
> > 
> > mrvl/sdsd8997_combo_v4.bin, from linux-firmware GIT, 16.92.21.p137
> > version. From an off-list chat with Rafael he confirmed me that this is
> > what he used for testing.
> 
> linux-firmware.git claims to hold W16.68.1.p197.1. Either WHENCE is
> wrong, or that sounds like a completely different branch. Are you sure
> about that?

Nope, I did a mistake :-). Wrong copy/paste.

[    5.956510] mwifiex_sdio mmc2:0001:1: info: FW download over, size 623352 bytes
...
[    6.825456] mwifiex_sdio mmc2:0001:1: WLAN FW is active
...
[   12.171950] mwifiex_sdio mmc2:0001:1: host_mlme: enable, key_api: 2
[   12.226206] mwifiex_sdio mmc2:0001:1: info: MWIFIEX VERSION: mwifiex 1.0 (16.68.1.p197)

root@...din-imx8mm-14700070:~# strings /lib/firmware/mrvl/sdsd8997_combo_v4.bin |grep 16
$Id: w8997o-V4, RF878X, FP68_LINUX, 16.68.1.p197.1 $

f62026ad508304fdadd9ebb5b500a6b4  /lib/firmware/mrvl/sdsd8997_combo_v4.bin

from commit 211fbc287a0b ("linux-firmware: Update FW files for MRVL SD8997 chips")

> The firmware versions above don't match up to me. But if we confirm
> that:
> (a) this API is available in a linux-firmware.git firmware for this chip
>     and
> (b) someone includes a valid linux-firmware.git version that they tested
>     in the changelog
> 
> then maybe this is OK. As it stands now though, no.

Right, my fault, now it should be clarified. Rafael, can you prepare a
v2 patch with all this information properly written in the commit message?

Francesco